OpenShift follow-up for NVBug 6218358#2166
Conversation
Greptile SummaryThis PR adds
|
| Filename | Overview |
|---|---|
| nemo_retriever/helm/openshift.md | New OpenShift install guide (restricted-v2 / PSA restricted): covers SCC overrides, prebuilt ffmpeg image, internal-registry pull secrets, NIM env defaults, and install examples. Env snippets correctly list chart defaults inline to avoid list-replacement surprises. |
| nemo_retriever/helm/README.md | OpenShift section trimmed to stub pointing to openshift.md; air-gapped snippet now explicitly sets name: "" to clear the ngc-secret default; service image updated from staging to GA. OCR v1 references remain in the air-gapped mirror table and NIM Operator sub-stack table, conflicting with the support matrix update in this PR. |
| docs/docs/extraction/prerequisites-support-matrix.md | OCR default updated from nemotron-ocr-v1:1.3.0 to nemotron-ocr-v2:1.4.0 in the support matrix table and notes. The chart's values.yaml still deploys nemotron-ocr-v1:1.3.0, creating a docs/code mismatch until PR #2259 lands. |
| docs/docs/extraction/deployment-options.md | Trims audio/video and OpenShift prose, replacing with cross-links to the Helm README sections. Clean change. |
| docs/mkdocs.yml | Adds OpenShift deployment (Helm) nav entry pointing to the new openshift.md via a GitHub blob URL, consistent with the existing pattern for other Helm chart links. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[User: OpenShift Helm Install] --> B{Image source?}
B -->|NGC NIM images| C[ngcImagePullSecret.name = ngc-secret]
B -->|Internal registry service image| D[ngcImagePullSecret.name = empty string]
B -->|Both| E[List both secrets under imagePullSecrets]
A --> F{Audio/video needed?}
F -->|Yes| G[Build custom image with ffmpeg baked in]
F -->|No| H[service.installFfmpeg: false]
A --> I[Apply openshift-restricted.yaml]
I --> J{NIM Operator?}
J -->|Service-only| K[nims.enabled=false]
J -->|In-cluster NIMs| L[NIM Operator + GPU Operator pre-installed]
L --> M{Optional NIMs crash?}
M -->|CrashLoopBackOff + missing .so| N[Add LD_LIBRARY_PATH to nimOperator env with chart defaults]
M -->|No issues| O[Ready]
K --> O
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
A[User: OpenShift Helm Install] --> B{Image source?}
B -->|NGC NIM images| C[ngcImagePullSecret.name = ngc-secret]
B -->|Internal registry service image| D[ngcImagePullSecret.name = empty string]
B -->|Both| E[List both secrets under imagePullSecrets]
A --> F{Audio/video needed?}
F -->|Yes| G[Build custom image with ffmpeg baked in]
F -->|No| H[service.installFfmpeg: false]
A --> I[Apply openshift-restricted.yaml]
I --> J{NIM Operator?}
J -->|Service-only| K[nims.enabled=false]
J -->|In-cluster NIMs| L[NIM Operator + GPU Operator pre-installed]
L --> M{Optional NIMs crash?}
M -->|CrashLoopBackOff + missing .so| N[Add LD_LIBRARY_PATH to nimOperator env with chart defaults]
M -->|No issues| O[Ready]
K --> O
Reviews (25): Last reviewed commit: "Merge upstream/main into docs/6218358-op..." | Re-trigger Greptile
Document RC9 QA findings: prebuilt ffmpeg image on restricted-v2, openshift-restricted values profile, internal registry pull secrets, optional NIM LD_LIBRARY_PATH overrides, and Omni caption smoke-test request shape. Cross-link from deployment-options and prerequisites-support-matrix.
Move Omni smoke-test note out of the chart admonition; use neutral link label to helm README anchor.
Add explicit #1-service-image anchor and Parakeet step-4 OpenShift caveat for installFfmpeg.
Replace matrix smoke-test prose with a one-line helm link per page roles. Show full nimOperator env lists in OpenShift LD_LIBRARY_PATH examples so Helm list overrides do not drop chart defaults.
Move Helm, OpenShift, and Omni smoke-test guidance out of the support matrix so deployment details stay on audio-video.md and the Helm README.
Extract restricted-v2 install procedures from the Helm README into docs/docs/extraction/openshift.md per review feedback. Helm README keeps a stub with cross-links; deployment-options and mkdocs nav point to the new page. Remove QA phrasing and fix ngcImagePullSecret name clearing.
Rewrite service-only and NIM Operator install intros as user actions instead of validation or QA repro language, per review on PR 2166.
Replace the removed QA validation paragraph with user-facing pod and NIMService checks plus guidance when optional ASR or Omni NIMs fail.
Clarify internal-registry pull secret wording and replace see-with-link CTAs with refer to so check-nrl-doc-leakage passes on PR 2166 files.
Replace via/once wording, drop code from headings, disambiguate caption links, and fix split refer-to link CTAs in the Helm README.
Clarify air-gap ngcImagePullSecret.name clearing and add copy-paste-safe LD_LIBRARY_PATH env examples with explicit chart defaults.
7c0cc4e to
8e99048
Compare
Rename the Helm README minimal-install section, keep a legacy blob/main, and use version-neutral prose in chart default notes.
This reverts commit 061c8ec.
Replace inline Helm value guidance in deployment-options with links to the audio-video and OpenShift sections per PR review.
Relocate OpenShift install content from the extraction doc site into the Helm chart directory per review. Update README, deployment-options, and mkdocs nav to link to the Helm-local guide.
0e91d1e to
c48738e
Compare
) Randy review OCR v2 defaults in the support matrix land in PR NVIDIA#2166; this branch keeps the remaining OCR v2 doc and chart updates.
Address PR NVIDIA#2166 review: main branch Helm chart defaults to Nemotron OCR v2 (nemotron-ocr-v2:1.4.0). Remaining OCR documentation and chart code in NVIDIA#2259.
c308bea to
65d63f5
Compare
Replace pre-release nvstaging references with the official NGC image that matches values.yaml. Update OpenShift install examples to match.
Summary
nemo_retriever/helm/openshift.mdas the OpenShift install guide (restricted-v2 / PSA restricted):openshift-restricted.yamlprofile, prebuilt ffmpeg service image, internal registry pull secrets (ngcImagePullSecret.name: ""), optional NIMLD_LIBRARY_PATHoverrides, direct Omni NIM/v1/chat/completionsexample, service-only and NIM Operator install flows, and post-install pod/NIMServicechecks.nemo_retriever/helm/README.mdto a short#openshift-deploymentstub linking to./openshift.md; chart values and generic Kubernetes guidance stay in the Helm README.prerequisites-support-matrix.md(Software Requirements ffmpeg bullet → one line toaudio-video.md; removed matrix Omni smoke-test cross-link).deployment-options.mdto defer Helm audio/video and OpenShift config to the Helm chart README sections (per review);docs/mkdocs.ymlnav links to the Helm-local OpenShift guide on GitHub.prerequisites-support-matrix.md: Helm default is Nemotron OCR v2 (nemotron-ocr-v2:1.4.0) onmain.Related
NVBugs
6218358 — OpenShift Helm chart SCC/PodSecurity documentation follow-up (comment #6).
PR scope check
mainnemo_retriever/helm/openshift.md(new),docs/docs/extraction/deployment-options.md,docs/docs/extraction/prerequisites-support-matrix.md,docs/mkdocs.yml,nemo_retriever/helm/README.mdTest plan
nemo_retriever/helm/openshift.mdon GitHub#openshift-deploymentstub links to./openshift.mdnemotron-ocr-v2:1.4.0)deployment-options.mdKubernetes/Helm section defers audio/video and OpenShift details to Helm README section headers