Skip to content

OpenShift follow-up for NVBug 6218358#2166

Merged
kheiss-uwzoo merged 22 commits into
NVIDIA:mainfrom
kheiss-uwzoo:docs/6218358-openshift-followup
Jun 22, 2026
Merged

OpenShift follow-up for NVBug 6218358#2166
kheiss-uwzoo merged 22 commits into
NVIDIA:mainfrom
kheiss-uwzoo:docs/6218358-openshift-followup

Conversation

@kheiss-uwzoo

@kheiss-uwzoo kheiss-uwzoo commented May 29, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Adds nemo_retriever/helm/openshift.md as the OpenShift install guide (restricted-v2 / PSA restricted): openshift-restricted.yaml profile, prebuilt ffmpeg service image, internal registry pull secrets (ngcImagePullSecret.name: ""), optional NIM LD_LIBRARY_PATH overrides, direct Omni NIM /v1/chat/completions example, service-only and NIM Operator install flows, and post-install pod/NIMService checks.
  • Trims nemo_retriever/helm/README.md to a short #openshift-deployment stub linking to ./openshift.md; chart values and generic Kubernetes guidance stay in the Helm README.
  • Fixes deploy leakage in prerequisites-support-matrix.md (Software Requirements ffmpeg bullet → one line to audio-video.md; removed matrix Omni smoke-test cross-link).
  • Updates deployment-options.md to defer Helm audio/video and OpenShift config to the Helm chart README sections (per review); docs/mkdocs.yml nav links to the Helm-local OpenShift guide on GitHub.
  • Addresses Randy OCR review on prerequisites-support-matrix.md: Helm default is Nemotron OCR v2 (nemotron-ocr-v2:1.4.0) on main.

Related

  • Remaining OCR v2 documentation and Helm chart implementation: #2259 (multimodal extraction, release notes, README/CLI, chart templates/values, tests).

NVBugs

6218358 — OpenShift Helm chart SCC/PodSecurity documentation follow-up (comment #6).

PR scope check

  • Base: main
  • Files changed: nemo_retriever/helm/openshift.md (new), docs/docs/extraction/deployment-options.md, docs/docs/extraction/prerequisites-support-matrix.md, docs/mkdocs.yml, nemo_retriever/helm/README.md
  • Red flags: none (docs only)

Test plan

  • Confirm mkdocs nav OpenShift deployment (Helm) links to nemo_retriever/helm/openshift.md on GitHub
  • Verify Helm README #openshift-deployment stub links to ./openshift.md
  • Confirm prerequisites matrix Software Requirements has no Helm/OpenShift/air-gap deploy prose
  • Confirm prerequisites matrix OCR note documents OCR v2 (nemotron-ocr-v2:1.4.0)
  • Confirm deployment-options.md Kubernetes/Helm section defers audio/video and OpenShift details to Helm README section headers
  • Spot-check OpenShift install examples read as user procedures (no QA references)

@kheiss-uwzoo kheiss-uwzoo requested review from a team as code owners May 29, 2026 16:15
@kheiss-uwzoo kheiss-uwzoo requested a review from charlesbluca May 29, 2026 16:15
@kheiss-uwzoo kheiss-uwzoo changed the title docs(helm): OpenShift follow-up for NVBugs 6218358 OpenShift follow-up for NVBugs 6218358 May 29, 2026
@greptile-apps

greptile-apps Bot commented May 29, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR adds nemo_retriever/helm/openshift.md as a dedicated OpenShift install guide (restricted-v2 / PSA restricted) and trims the Helm README's OpenShift section to a stub that links to it. Other changes redirect audio/video and OpenShift Kubernetes prose to the new guide, update the mkdocs nav, and fix the air-gapped snippet to explicitly clear ngcImagePullSecret.name.

  • New openshift.md: covers SCC/PSA overrides, prebuilt ffmpeg image, internal-registry pull secrets, full NIM env lists (addressing the previous LD_LIBRARY_PATH list-replacement issue), Omni NIM direct-call example, service-only and NIM Operator install flows, and vectordb/otel patch procedures.
  • OCR v1 → v2 update in prerequisites-support-matrix.md: the support matrix table and note now document nemotron-ocr-v2:1.4.0 as the Helm default, but values.yaml and the Helm README's mirror table still reference nemotron-ocr-v1:1.3.0 — the chart update is deferred to PR Switch default OCR from v1 to v2 on main #2259.
  • ngcImagePullSecret.name: "" added to the air-gapped values snippet in README.md to explicitly clear the "ngc-secret" default (addresses previous review comment).

Confidence Score: 4/5

Safe to merge once the OCR version discrepancy between the support matrix and the chart/README is resolved or explicitly gated on PR #2259.

The support matrix now documents nemotron-ocr-v2:1.4.0 as the Helm default, but values.yaml still deploys nemotron-ocr-v1:1.3.0 and the Helm README air-gapped mirror table still lists v1. Users installing the current chart while following these updated docs will get the wrong OCR NIM with no warning.

docs/docs/extraction/prerequisites-support-matrix.md and nemo_retriever/helm/README.md — OCR version references need to be aligned with the actual chart default (values.yaml line 961) before or alongside this merge.

Important Files Changed

Filename Overview
nemo_retriever/helm/openshift.md New OpenShift install guide (restricted-v2 / PSA restricted): covers SCC overrides, prebuilt ffmpeg image, internal-registry pull secrets, NIM env defaults, and install examples. Env snippets correctly list chart defaults inline to avoid list-replacement surprises.
nemo_retriever/helm/README.md OpenShift section trimmed to stub pointing to openshift.md; air-gapped snippet now explicitly sets name: "" to clear the ngc-secret default; service image updated from staging to GA. OCR v1 references remain in the air-gapped mirror table and NIM Operator sub-stack table, conflicting with the support matrix update in this PR.
docs/docs/extraction/prerequisites-support-matrix.md OCR default updated from nemotron-ocr-v1:1.3.0 to nemotron-ocr-v2:1.4.0 in the support matrix table and notes. The chart's values.yaml still deploys nemotron-ocr-v1:1.3.0, creating a docs/code mismatch until PR #2259 lands.
docs/docs/extraction/deployment-options.md Trims audio/video and OpenShift prose, replacing with cross-links to the Helm README sections. Clean change.
docs/mkdocs.yml Adds OpenShift deployment (Helm) nav entry pointing to the new openshift.md via a GitHub blob URL, consistent with the existing pattern for other Helm chart links.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[User: OpenShift Helm Install] --> B{Image source?}
    B -->|NGC NIM images| C[ngcImagePullSecret.name = ngc-secret]
    B -->|Internal registry service image| D[ngcImagePullSecret.name = empty string]
    B -->|Both| E[List both secrets under imagePullSecrets]

    A --> F{Audio/video needed?}
    F -->|Yes| G[Build custom image with ffmpeg baked in]
    F -->|No| H[service.installFfmpeg: false]

    A --> I[Apply openshift-restricted.yaml]

    I --> J{NIM Operator?}
    J -->|Service-only| K[nims.enabled=false]
    J -->|In-cluster NIMs| L[NIM Operator + GPU Operator pre-installed]

    L --> M{Optional NIMs crash?}
    M -->|CrashLoopBackOff + missing .so| N[Add LD_LIBRARY_PATH to nimOperator env with chart defaults]
    M -->|No issues| O[Ready]
    K --> O
Loading
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
    A[User: OpenShift Helm Install] --> B{Image source?}
    B -->|NGC NIM images| C[ngcImagePullSecret.name = ngc-secret]
    B -->|Internal registry service image| D[ngcImagePullSecret.name = empty string]
    B -->|Both| E[List both secrets under imagePullSecrets]

    A --> F{Audio/video needed?}
    F -->|Yes| G[Build custom image with ffmpeg baked in]
    F -->|No| H[service.installFfmpeg: false]

    A --> I[Apply openshift-restricted.yaml]

    I --> J{NIM Operator?}
    J -->|Service-only| K[nims.enabled=false]
    J -->|In-cluster NIMs| L[NIM Operator + GPU Operator pre-installed]

    L --> M{Optional NIMs crash?}
    M -->|CrashLoopBackOff + missing .so| N[Add LD_LIBRARY_PATH to nimOperator env with chart defaults]
    M -->|No issues| O[Ready]
    K --> O
Loading

Reviews (25): Last reviewed commit: "Merge upstream/main into docs/6218358-op..." | Re-trigger Greptile

Comment thread nemo_retriever/helm/README.md Outdated
@kheiss-uwzoo kheiss-uwzoo changed the title OpenShift follow-up for NVBugs 6218358 docs(helm): OpenShift follow-up for NVBugs 6218358 May 29, 2026
@kheiss-uwzoo kheiss-uwzoo changed the title docs(helm): OpenShift follow-up for NVBugs 6218358 OpenShift follow-up for NVBug 6218358 May 29, 2026
Comment thread nemo_retriever/helm/README.md Outdated
Comment thread nemo_retriever/helm/README.md Outdated
@kheiss-uwzoo kheiss-uwzoo added the doc Improvements or additions to documentation label May 29, 2026
Comment thread docs/docs/extraction/prerequisites-support-matrix.md Outdated
Comment thread docs/docs/extraction/prerequisites-support-matrix.md Outdated
Comment thread nemo_retriever/helm/README.md Outdated
Comment thread nemo_retriever/helm/README.md Outdated
Comment thread nemo_retriever/helm/README.md Outdated
Document RC9 QA findings: prebuilt ffmpeg image on restricted-v2, openshift-restricted values profile, internal registry pull secrets, optional NIM LD_LIBRARY_PATH overrides, and Omni caption smoke-test request shape. Cross-link from deployment-options and prerequisites-support-matrix.
Move Omni smoke-test note out of the chart admonition; use neutral link label to helm README anchor.
Add explicit #1-service-image anchor and Parakeet step-4 OpenShift caveat for installFfmpeg.
Replace matrix smoke-test prose with a one-line helm link per page roles.
Show full nimOperator env lists in OpenShift LD_LIBRARY_PATH examples so
Helm list overrides do not drop chart defaults.
Move Helm, OpenShift, and Omni smoke-test guidance out of the support
matrix so deployment details stay on audio-video.md and the Helm README.
Extract restricted-v2 install procedures from the Helm README into
docs/docs/extraction/openshift.md per review feedback. Helm README keeps
a stub with cross-links; deployment-options and mkdocs nav point to the
new page. Remove QA phrasing and fix ngcImagePullSecret name clearing.
Rewrite service-only and NIM Operator install intros as user actions
instead of validation or QA repro language, per review on PR 2166.
Replace the removed QA validation paragraph with user-facing pod and
NIMService checks plus guidance when optional ASR or Omni NIMs fail.
Clarify internal-registry pull secret wording and replace see-with-link CTAs with refer to so check-nrl-doc-leakage passes on PR 2166 files.
Replace via/once wording, drop code from headings, disambiguate caption links, and fix split refer-to link CTAs in the Helm README.
Clarify air-gap ngcImagePullSecret.name clearing and add copy-paste-safe LD_LIBRARY_PATH env examples with explicit chart defaults.
@kheiss-uwzoo kheiss-uwzoo force-pushed the docs/6218358-openshift-followup branch from 7c0cc4e to 8e99048 Compare June 11, 2026 23:35
@kheiss-uwzoo kheiss-uwzoo self-assigned this Jun 16, 2026
Comment thread nemo_retriever/helm/README.md
Rename the Helm README minimal-install section, keep a legacy
blob/main, and use version-neutral prose in chart default notes.
Comment thread docs/docs/extraction/deployment-options.md Outdated
Comment thread nemo_retriever/helm/openshift.md
Comment thread docs/docs/extraction/prerequisites-support-matrix.md Outdated
Comment thread docs/mkdocs.yml Outdated
Comment thread nemo_retriever/helm/README.md Outdated
Replace inline Helm value guidance in deployment-options with links to the
audio-video and OpenShift sections per PR review.
Relocate OpenShift install content from the extraction doc site into the Helm
chart directory per review. Update README, deployment-options, and mkdocs nav
to link to the Helm-local guide.
@kheiss-uwzoo kheiss-uwzoo force-pushed the docs/6218358-openshift-followup branch from 0e91d1e to c48738e Compare June 22, 2026 18:11
kheiss-uwzoo added a commit to kheiss-uwzoo/nv-ingest that referenced this pull request Jun 22, 2026
)

Randy review OCR v2 defaults in the support matrix land in PR NVIDIA#2166;
this branch keeps the remaining OCR v2 doc and chart updates.
Address PR NVIDIA#2166 review: main branch Helm chart defaults to Nemotron OCR v2
(nemotron-ocr-v2:1.4.0). Remaining OCR documentation and chart code in NVIDIA#2259.
@kheiss-uwzoo kheiss-uwzoo force-pushed the docs/6218358-openshift-followup branch from c308bea to 65d63f5 Compare June 22, 2026 20:37
Replace pre-release nvstaging references with the official NGC image that
matches values.yaml. Update OpenShift install examples to match.
@kheiss-uwzoo kheiss-uwzoo merged commit ee32309 into NVIDIA:main Jun 22, 2026
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants