Skip to content

fix: install header patterns use wrong csrc/ prefix and missing #6051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andrewwhitecdw wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Open

fix: install header patterns use wrong csrc/ prefix and missing #6051

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -565,9 +565,9 @@ install(DIRECTORY "${NVFUSER_SRCS_DIR}/"
DESTINATION "${CMAKE_INSTALL_INCLUDEDIR}/nvfuser"
FILES_MATCHING
PATTERN "*.h"
PATTERN "csrc/C++20/compare"
PATTERN "csrc/C++23/utility"
PATTERN "csrc/struct.inl")
PATTERN "C++20/compare" EXCLUDE
PATTERN "C++23/utility" EXCLUDE
PATTERN "struct.inl" EXCLUDE)
Comment on lines +569 to +570

@greptile-apps greptile-apps Bot Aug 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Required transitive headers excluded

When downstream consumers compile the installed base.h or polymorphic_value.h, these rules exclude the extensionless C++23/utility and struct.inl headers that they unconditionally include, causing compilation to fail with missing-header errors.

Suggested change
PATTERN "C++23/utility" EXCLUDE
PATTERN "struct.inl" EXCLUDE)
PATTERN "C++23/utility"
PATTERN "struct.inl")


# installing dynamic_type headers
install(DIRECTORY "${NVFUSER_ROOT}/lib/dynamic_type/src/dynamic_type"
Expand Down