Skip to content

fix: typo in nvfuser_common/lib ignore pattern - #6050

Open
andrewwhitecdw wants to merge 1 commit into
NVIDIA:mainfrom
andrewwhitecdw:bugfix/gitignore-typo-in-nvfuser-common-lib-ignore
Open

fix: typo in nvfuser_common/lib ignore pattern#6050
andrewwhitecdw wants to merge 1 commit into
NVIDIA:mainfrom
andrewwhitecdw:bugfix/gitignore-typo-in-nvfuser-common-lib-ignore

Conversation

@andrewwhitecdw

Copy link
Copy Markdown

This PR fixes a typo in .gitignore: typo in nvfuser_common/lib ignore pattern.

Changes

  • .gitignore: typo in nvfuser_common/lib ignore pattern.

Details

--- a/.gitignore
+++ b/.gitignore
@@ -1,5 +1,5 @@
-nvfuser_common/version.py
-nvfuser_common/include
-nvfuser_comon/lib
-nvfuser_common/share
-nvfuser_common/cmake
+nvfuser_common/version.py
+nvfuser_common/include
+nvfuser_common/lib
+nvfuser_common/share
+nvfuser_common/cmake

Tests

  • tests/test_repo_config.py
diff --git a/tests/test_repo_config.py b/tests/test_repo_config.py
new file mode 100644
--- /dev/null
+++ b/tests/test_repo_config.py
@@ -0,0 +1,39 @@
+import unittest
+from pathlib import Path
+
+
+REPO_ROOT = Path(__file__).resolve().parent.parent
+
+
+class TestGitignore(unittest.TestCase):
+    def test_nvfuser_common_lib_ignored(self):
+        gitignore = (REPO_ROOT / ".gitignore").read_text()
+        self.assertIn("nvfuser_common/lib", gitignore)
+        self.assertNotIn("nvfuser_comon/lib", gitignore)
+
+
+class TestLintWorkflow(unittest.TestCase):
+    def test_clang_tidy_step_handles_empty_file_list(self):
+        workflow = (REPO_ROOT / ".github" / "workflows" / "lint.yml").read_text()
+        self.assertIn('if [ -n "$files" ]', workflow)
+        self.assertIn("xargs -r", workflow)
+        self.assertNotIn(
+            'git --no-pager diff --diff-filter=d --name-only $head_commit | grep -e "csrc/.*\.cpp" -e "csrc/.*\.h" | xargs lintrunner --take CLANGTIDY --force-color',
+            workflow,
+        )
+
+
+if __name__ == "__main__":
+    unittest.main()

Signed-off-by: andrewwhitecdw <andrewwhitecdw@users.noreply.github.com>
@greptile-apps

greptile-apps Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Corrects a typo in .gitignore so generated libraries under nvfuser_common/lib are ignored as intended.

  • Replaces the misspelled nvfuser_comon/lib pattern with nvfuser_common/lib.

Confidence Score: 5/5

The PR appears safe to merge because it only corrects an ignore pattern for generated build artifacts.

The corrected path aligns with the build-generated nvfuser_common library directory and does not hide maintained source files.

Important Files Changed

Filename Overview
.gitignore Correctly updates the generated-library ignore path with no actionable issues identified.

Reviews (1): Last reviewed commit: "fix: typo in nvfuser_common/lib ignore p..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant