Repository navigation
Conversation
Signed-off-by: Miyoung Choi <miyoungc@nvidia.com>
|
Staged Fern docs preview: https://nvidia-preview-pr-2475.docs.buildwithfern.com/nemo/guardrails |
Signed-off-by: Miyoung Choi <miyoungc@nvidia.com>
[Medium impact] The PR appears safe to merge; the previous comparison gap is fixed and no new actionable issues were found. SummaryThe PR generates OpenAPI from FastAPI during documentation builds and keeps curated API details in a Fern overlay.
|
| uv run --locked python scripts/openai_coverage.py \ | ||
| --openai-spec /tmp/openai-spec.yml --check-breaking \ | ||
| --base-ref "$BASE_REF" |
There was a problem hiding this comment.
Response changes escape checks
The breaking-change check still reads only fern/openapi.yml, but this PR moves response shapes such as ErrorResponse and RailsConfigInfo into fern/openapi-overlay.yml. Changes to those shapes now escape the comparison, and overlay-only changes do not trigger this workflow.
Compare the overlay-applied specifications from both revisions, and trigger the workflow on overlay changes.
Prompt To Fix With AI
This is a comment left during a code review.
Path: .github/workflows/api-conformance-docs.yml
Line: 74-76
Comment:
**Response changes escape checks**
The breaking-change check still reads only `fern/openapi.yml`, but this PR moves response shapes such as `ErrorResponse` and `RailsConfigInfo` into `fern/openapi-overlay.yml`. Changes to those shapes now escape the comparison, and overlay-only changes do not trigger this workflow.
Compare the overlay-applied specifications from both revisions, and trigger the workflow on overlay changes.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Signed-off-by: Miyoung Choi <miyoungc@nvidia.com>
Signed-off-by: Miyoung Choi <miyoungc@nvidia.com>
Signed-off-by: Miyoung Choi <miyoungc@nvidia.com>
Signed-off-by: Miyoung Choi <miyoungc@nvidia.com>
Signed-off-by: Miyoung Choi <miyoungc@nvidia.com>
Signed-off-by: Miyoung Choi <miyoungc@nvidia.com>
There was a problem hiding this comment.
I'm wondering why it's being called overlay? I think the agent is conflating some concepts from the new experimental server
There was a problem hiding this comment.
better to rename this, one can confuse it with openai's API spec
Description
The API reference currently depends on a handwritten OpenAPI file that can drift from the FastAPI server. Generate the contract during documentation builds, alongside the Python SDK reference, so a source change updates the built API reference automatically. Contributors commit the source and curated documentation;
fern/openapi.ymlbecomes an ignored build artifact.fern/openapi-overlay.yml, and add/v1/checksto navigation.Related Issue(s)
Tracking: SDR-1591. The request originated in Slack and is tracked on the SDR documentation board, as authorized by the directing contributor.
Verification
22f56ec027fde7b9503ef17340d9097ed2f683e8, with no pending or failed PR checks. Successful checks include Python 3.10–3.13 on Ubuntu, coverage, OpenAPI generation, both API conformance jobs, Fern validation and preview publishing, lint, zizmor, CodeQL, and Greptile. The separately dispatched Full Tests matrix also passes all eight Windows/macOS combinations across Python 3.10–3.13 on this exact commit. Staging publishing was intentionally skipped.npm run test:docs-scriptswith Node.js 22: 18 passed. Covers missing/stale artifacts, failure blocking undermake -j2, historical SDK caching and inherited Fern context, source-change watching, and native Fern compilation/export.make docs-fernwith Node.js 22 and the organization-required Fern CLI 5.167.0: passed, regenerating OpenAPI and 406 SDK pages with 0 errors and 566 existing warnings. The generated artifacts remain ignored and untracked.RailsConfigInfo.idfailed the pinned oasdiff check withresponse-required-property-removed, confirming overlay response changes are covered.The PR preview was published successfully. No staging or production publication was performed. The earlier Windows failures were reproduced by the full platform matrix, and the Fern 5.167.0 image-path failure was reproduced locally before the fix (7 errors) and cleared afterward (0 errors).
AI Assistance
OpenAI Codex implemented the exporter, overlay, build/workflow wiring, documentation, and regression tests, and ran local validation. Human review is pending.
Checklist
Summary by CodeRabbit
New Features
POST /v1/checksendpoint.Documentation