Skip to content

fail if there is a mismatch in the number of iterations - #245

Merged
scarlehoff merged 4 commits into
mainfrom
scarlehoff-patch-1
Apr 10, 2026
Merged

scarlehoff merged 4 commits into
mainfrom
scarlehoff-patch-1

Conversation

@scarlehoff

Copy link
Copy Markdown
Member

No description provided.

@felixhekhorn felixhekhorn added the refactor Refactor code label Apr 10, 2026
@scarlehoff

Copy link
Copy Markdown
Member Author

Funny, the bechmarks are using inconsistent iterations :)

@felixhekhorn

Copy link
Copy Markdown
Contributor

Funny, the bechmarks are using inconsistent iterations :)

it just proves the point 🙈 can you please fix the files on the server?

PS: @Radonirinaunimi #215 has an explicit item in the todo list 🙈

@Radonirinaunimi

Copy link
Copy Markdown
Member

Funny, the bechmarks are using inconsistent iterations :)

it just proves the point 🙈 can you please fix the files on the server?

PS: @Radonirinaunimi #215 has an explicit item in the todo list 🙈

Indeed - which is supposed to be ultimate benchmark/regression tests and is operational.

@felixhekhorn felixhekhorn changed the title fail if there is a mismatch in the number of iteraitons fail if there is a mismatch in the number of iterations Apr 10, 2026
@scarlehoff

Copy link
Copy Markdown
Member Author

It's a bit more complicated than that, it is also using old datasets. The yamldb. Truncated. It was never updated to 4.1.

Let me fix the benchmark so it passes and later we redo the regression test.

@scarlehoff
scarlehoff merged commit a56f06f into main Apr 10, 2026
6 checks passed
@scarlehoff
scarlehoff deleted the scarlehoff-patch-1 branch August 3, 2026 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Refactor code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants