Jd/geometry branch switch base - #198
Merged
Merged
Conversation
- aggregate_components: accept groups of 2 (not just 3) for open-wye/open-delta configs - distribution_system: refactor cycle-breaking into _break_cycle helper, fix adjacent switch edge removal
- Add reachability check after cycle breaking in get_directed_graph - Log warning with count and list of isolated node names
…on check The _break_cycle static method is inlined back into the cycle-breaking loop. The post-cycle isolation check is removed now that models are properly converted with open switches.
Documents 2-unit transformer aggregation, DFS tree helper, cycle breaking improvements, and open switch pruning.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
This pull request adds support for aggregating groups of 2 parallel single-phase transformers or regulators (open-wye/open-delta configurations) in addition to groups of 3, and documents several improvements to the directed graph processing logic. The most important changes are:
Transformer aggregation enhancements
aggregate_single_phase_transformers(system)function now merges groups of 2 or 3 parallel single-phase transformers/regulators into a multi-phase equivalent, instead of only supporting groups of 3. Groups with fewer than 2 or more than 3 units are skipped. [1] [2]docs/new_features.ipynbhave been updated to describe the new behavior and supported configurations. [1] [2]Directed graph improvements (documented)
Related issue number
Checklist