Repository navigation
Fix Deadlock and Log Corruption During Active Tasks - #18
Conversation
This commit addresses the issue where asynchronous logging during active tasks caused deadlocks or terminal output corruption. 1. Bypassed mutex acquisition in `Logger.print` if there are pending tasks. This allows direct writes to the stream, which are safely intercepted by our hook, avoiding deadlock with the render loop. 2. Implemented `pendingBuffer` in `hook.ts` to buffer incomplete log lines and avoid breaking terminal layout during active task displays. 3. Updated `render.ts` to prepend buffered incomplete lines to the interactive task list and flush on termination/cleanup. 4. Added unit tests for deadlock prevention and partial line buffering.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
Fixes deadlock/hanging and log corruption when logs are written asynchronously while an interactive task is rendering. It avoids deadlock by allowing direct stream writes when
isPending()is true, and introducespendingBufferto correctly aggregate, render, and flush partial terminal lines.PR created automatically by Jules for task 10899409696913749581 started by @Mopsgamer