Repository navigation
Consolidated cleanup on process interruption - #16
Conversation
- Introduced a `cleanup()` function in `render.ts` to consolidate terminal erasure logic. - Updated `SIGINT`, `SIGTERM`, and `uncaughtException` handlers to use `cleanup()`. - Ensured `logu.clear()` is wrapped with `hookState.isHooking` to avoid recursive hooks. - Reordered code for proper initialization of the interactive logger. - Removed all code duplication in signal handlers.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This PR ensures that the library leaves a clean terminal state when the process is interrupted or terminated. It addresses the issue of "multiple empty lines" or leftover task output being left behind.
Key Improvements:
SIGINT,SIGTERM, anduncaughtException.PR created automatically by Jules for task 8609402056546744438 started by @Mopsgamer