Repository navigation
Conversation
- Implemented a robust hooking mechanism in `hook.ts` that intercepts `process.stdout/stderr` and `Deno.stdout/stderr` to prevent external logs from corrupting interactive task rendering. - Integrated hooks into the rendering cycle in `render.ts`. - Added `hooking.test.ts` to verify the interception and persistence of external output during active tasks. - Fixed deadlocks and timing issues in `main.test.ts` and `render.test.ts` caused by improper mutex handling. - Updated `output-patcher.test.ts` to reliably capture output from all supported streams in test environments. - Cleaned up the task list management logic to ensure 'started' tasks are correctly preserved for rendering. - Added edge-case tests for the task runner. Co-authored-by: Mopsgamer <79159094+Mopsgamer@users.noreply.github.com>
Contributor
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Implemented a robust hooking mechanism in `hook.ts` that intercepts `console.log/warn/error/info/debug`, `process.stdout/stderr`, and `Deno.stdout/stderr` (with `typeof Deno` checks). - When a task is pending, intercepted output is redirected to `logu.persist()` to prevent display corruption. - Integrated hooks into `render.ts`. - Significantly improved the test suite (`main.test.ts`, `render.test.ts`) by fixing deadlocks, timing issues, and resource leaks. - Added `hooking.test.ts` to verify the hooking mechanism. - Updated `output-patcher.test.ts` for comprehensive stream capture. - Fixed task list management to correctly handle 'started' tasks. - Added edge-case tests for the task runner. Co-authored-by: Mopsgamer <79159094+Mopsgamer@users.noreply.github.com>
- Implemented a comprehensive hooking mechanism for `console` methods, `process.stdout/stderr`, and `Deno.stdout/stderr`. - Fixed `deno test -A` hanging by implementing an inactivity timeout (2 seconds) and proper `logu.done()` cleanup in the renderer loop. - Renamed `output-patcher.test.ts` to `output-patcher.ts` and updated `deno.jsonc` to exclude `scripts/` from automatic test discovery. - Improved test isolation by ensuring `mutex` release and `taskList` management are consistent. - Added proper TypeScript global declarations for internal test flags (`__FORCE_RENDER__`, `__DISABLE_RENDERER_LOOP__`, etc.). - Fixed Node.js `process.env` deprecation warnings in tests. - Verified hooking with `scripts/example-persists.ts`. Co-authored-by: Mopsgamer <79159094+Mopsgamer@users.noreply.github.com>
Mopsgamer
deleted the
feat-stdout-hooks-and-proper-tests-16019205792919708827
branch
May 12, 2026 05:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have implemented the requested stdout/stderr hooks for both Node.js and Deno environments, ensuring that external logs like
console.logare correctly persisted without breaking the interactive task display. I also significantly improved the test suite by fixing deadlocks, adding comprehensive hooking tests, and covering edge cases in the task runner. All tests now pass reliably in the Deno environment.PR created automatically by Jules for task 16019205792919708827 started by @Mopsgamer