fix(tui): show detached HEAD in git status#602
Open
lurenjia534 wants to merge 1 commit into
Open
Conversation
🦋 Changeset detectedLatest commit: 5166916 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Resolve #566
Problem
See linked issue. In a detached HEAD checkout,
git branch --show-currentreturns an empty string even though the working directory is still a valid git repository. The footer could therefore drop useful git context instead of showing which commit is checked out.What changed
git rev-parse --short HEADwhen no branch name is available and displaydetached@<short-sha>.Verification
corepack pnpm vitest run apps/kimi-code/test/utils/git/git-status.test.tscorepack pnpm --filter @moonshot-ai/kimi-code run typecheckcorepack pnpm lint(515 warnings, 0 errors; warnings are existing repository-wide lint warnings)corepack pnpm --filter @moonshot-ai/kimi-code run buildand manually verified the footer in a detached checkoutNote: full
corepack pnpm testwas also run locally on Windows before opening this PR and failed on unrelated existing Windows/path/process snapshot failures; the focused regression test above passes.Checklist
gen-changesetsskill, or this PR needs no changeset.gen-docsskill, or this PR needs no doc update.