Repository navigation
docs: correct contract upgrade claims to state deployed contracts - #1160
Merged
Miracle656 merged 1 commit intoOct 22, 2026
Merged
Miracle656 merged 1 commit into
Miracle656 merged 1 commit into
Conversation
|
@Anorakthegr8 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
@Anorakthegr8 is attempting to deploy a commit to the miracle656's projects Team on Vercel. A member of the Team first needs to authorize it. |
Miracle656
added a commit
that referenced
this pull request
Oct 22, 2026
jest (frontend/wallet) 78 suites, 1182 passing
tsc (frontend/mobile) 2 errors, both pre-existing on main -- the /verify
dead route (#1200, still open) and the SDK react
peer dep from a local install
#1220 link the npm package back to its source and docs (#1214)
#1197 distinguish passkey cancellation from refusal (#1183)
#1193 wallet contracts threat model (#1188)
#1191 recovery breadcrumbs verified by name and shape (#1177)
#1194 detect duplicate SPP pool deployments
#1160 correct the contract upgrade claims in the docs (#1147)
#1197 is the one worth calling out. A user cancelling a passkey prompt is not
an error, and treating it as one is how an app teaches people it is broken.
passkeyOutcome.ts now separates cancelled, refused-by-authenticator and
genuinely failed, with tests for each -- and the swap and vault pages use it,
so it is wired rather than available.
#1160 closes the loop on #1147: the public docs claimed two contract upgrade
paths that did not exist. They now say what is true -- deployed contracts are
permanent -- which matters more than usual given we have just added
set_wasm_hash to the factory (#1189). A new factory is still a new address.
#1191 adds scripts/verify-breadcrumbs.mjs, so the data entries recovery
depends on are asserted by name and shape rather than assumed. That is the
check that only pays off on the day someone has lost their device.
Claude-Session: https://claude.ai/code/session_01USgemLt4Rnz4SGB1Srf3GB
Miracle656
pushed a commit
that referenced
this pull request
Oct 22, 2026
… two test modules The 'Merge PR #1220 #1197 #1193 #1191 #1194 #1160' conflict resolution left mod operator_refusal_tests and mod spend_limit_tests ungated in lib.rs, so every non-test build — cargo build, the reproducible build, Release — fails on soroban_sdk::testutils imports that only exist under cfg(test). Contract CI stayed green because cargo test compiles with the test cfg, which is why this slipped through. cargo build --all compiles again; invisible-wallet suite 144/144. expected-hashes.json follows in a second commit from this PR's own reproducible-build log, since main cannot currently produce a release wasm to hash at all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Corrects public contract upgrade documentation across the docs site to align with actual on-chain contract code and
docs/CONTRACTS_V2.md:update_current_contract_wasmandset_wasm_hash) infrontend/docs/pages/contract-upgrades.mdxwith accurate descriptions of contract immutability.__constructor,init, anddeploy), clarifying thatstorage::set_wasm_hashis an internal helper.architecture.mdx,security.mdx, andcontract-api.mdxwith the immutability model.docs/CONTRACTS_V2.md.Related issue
Closes #1147
Type of change
Component
Checklist
cargo testpasses (contracts)npm run typecheckpasses (wallet / sdk / agent)npm run buildpasses (wallet / agent)Screenshots / test output
node scripts/generate-sitemap.mjssuccessfully (23 pages indexed).npm run verify:lockfileclean.--fn upgrade,--fn set_wasm_hash) remain in the codebase.