refactor: share file upload operation - #229
Conversation
NianJiuZst
left a comment
There was a problem hiding this comment.
No blocking findings on the current head. The shared upload operation preserves CLI dry-run/output behavior and SDK-specific errors while consolidating multipart construction, so I recommend merging it.
Verified locally: typecheck, lint (one pre-existing warning), build, 7 focused upload/SDK tests, and the full suite (450/450). If #228 lands first, rebase and re-run the file SDK tests because both PRs touch src/sdk/file/index.ts.
NianJiuZst
left a comment
There was a problem hiding this comment.
No blocking findings after revalidating this head against the latest main. The shared upload operation preserves CLI dry-run/output behavior and SDK-specific error identities while consolidating multipart construction, so I recommend merging it after #208.
Verified: focused multipart tests, typecheck, lint (one pre-existing warning), and the combined #208 + #229 full suite (402/402).
What changed
Why
The CLI and SDK previously maintained separate upload implementations, so fixes could land in one path and be missed in the other.
Impact
CLI and SDK behavior stays compatible while the upload protocol now has a single implementation and stronger multipart coverage.
Checks
bun test— 450 passedbun run typecheckbun run buildbun run lint— no errors; one pre-existing test warninggit diff --checkNeed help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.