fix: enforce H3 reference input limit - #222
Draft
shaoohh wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The H3 validator checked each media type independently but did not check their combined count. A request containing 9 reference images, 3 reference videos, and 3 reference audios therefore passed local validation with 15 total references, even though mixed-reference requests allow at most 12.
Impact
Oversized mixed-reference requests now fail locally with an actionable usage error before a paid generation request is submitted.
Validation
bun test test/video/v2.test.ts— 12 passedbun test— 450 passedbun run typecheckbun run lint— 0 errors; 1 pre-existing warning intest/sdk/speech.test.tsbun run buildNeed help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.