Skip to content

chore(ci): make lint checks non-mutating#523

Merged
TheRealAgentK merged 1 commit into
developfrom
chore/non-mutating-lint-ci
Jul 20, 2026
Merged

chore(ci): make lint checks non-mutating#523
TheRealAgentK merged 1 commit into
developfrom
chore/non-mutating-lint-ci

Conversation

@TheRealAgentK

Copy link
Copy Markdown
Contributor

Summary

  • make npm run eslint and npm run tseslint check-only instead of silently modifying files in CI
  • add explicit eslint:fix and tseslint:fix scripts for intentional local fixes
  • disable @stylistic/indent-binary-ops, which conflicts with Prettier's formatting of TypeScript union types

Motivation

After the development-tool refresh, npm run tseslint exited successfully while changing lib/raygun.ts; that ESLint-produced change then failed Prettier. CI did not catch the inconsistency because lint and formatting run in separate workspaces and the lint scripts used --fix.

Prettier remains the formatting authority, while ESLint now performs non-mutating static analysis in CI.

Verification

  • npm ci
  • npm run eslint — passed without changing tracked files
  • npm run tseslint — passed without changing tracked files
  • npm run eslint:fix — passed
  • npm run tseslint:fix — passed without conflicting with Prettier
  • repository Prettier check
  • npm test — 258 tests passed
  • npm run test:cjs
  • npm audit — 0 vulnerabilities
  • git diff --check

@TheRealAgentK
TheRealAgentK merged commit 0d450d7 into develop Jul 20, 2026
5 checks passed

@Olwiba Olwiba left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants