chore(ci): make lint checks non-mutating#523
Merged
Merged
Conversation
velocitysystems
approved these changes
Jul 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npm run eslintandnpm run tseslintcheck-only instead of silently modifying files in CIeslint:fixandtseslint:fixscripts for intentional local fixes@stylistic/indent-binary-ops, which conflicts with Prettier's formatting of TypeScript union typesMotivation
After the development-tool refresh,
npm run tseslintexited successfully while changinglib/raygun.ts; that ESLint-produced change then failed Prettier. CI did not catch the inconsistency because lint and formatting run in separate workspaces and the lint scripts used--fix.Prettier remains the formatting authority, while ESLint now performs non-mutating static analysis in CI.
Verification
npm cinpm run eslint— passed without changing tracked filesnpm run tseslint— passed without changing tracked filesnpm run eslint:fix— passednpm run tseslint:fix— passed without conflicting with Prettiernpm test— 258 tests passednpm run test:cjsnpm audit— 0 vulnerabilitiesgit diff --check