Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions .github/workflows/lab1-smoke.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
name: Lab 1 juiceshop Smoke Test

on:
pull_request:
branches: ["main"]

permissions:
contents: read

jobs:
smoke-test-juice-shop:
runs-on: ubuntu-latest

services:
juice-shop:
image: bkimminich/juice-shop:v20.0.0
ports:
- 3000:3000

steps:
- name: Wait for Juice Shop
run: |
for i in $(seq 1 30); do
if curl --silent --fail http://localhost:3000/rest/admin/application-version; then
echo "Juice Shop is ready"
exit 0
fi
echo "Waiting for Juice Shop..."
sleep 2
done
echo "Juice Shop did not start in time"
exit 1

- name: Verify homepage HTTP 200
run: |
curl --silent --fail --head http://localhost:3000
Binary file added submissions/embeddings/l1_pr.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
14 changes: 8 additions & 6 deletions submissions/lab1.md
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ Required checklist (the template must include all three items):
- File: `.github/PULL_REQUEST_TEMPLATE.md`
- Sections included: Goal / Changes / Testing / Artifacts / Checklist / Personal Notes
- Checklist items: Title is clear (`feat(labN): <topic>`), No secrets/large temp files committed, `submissions/labN.md` exists
- Auto-fill verified: [x] Yes — PR description showed my template [pr](embeddings/l1_pr.png)
- Auto-fill verified: [x] Yes — PR description showed my template [pr](embeddings/l1_pr.png) or [pr on github](https://github.com/MikeNovikoff/DevSecOps-Intro-Mike/pull/2/commits/7cc7549e3a16558a963ae2dafb41d6c8b8dafc20)


---
Expand All @@ -117,11 +117,6 @@ Required checklist (the template must include all three items):
- TA: [@pierrepicaud](https://github.com/pierrepicaud)
4. **Follow** at least 3 classmates from the course

**Add to `submissions/lab1.md`:**

A "GitHub Community" section with 1-2 sentences explaining:
- Why starring repositories matters in open source
- How following developers helps in team projects and professional growth

<details>
<summary>💡 GitHub Social Features</summary>
Expand All @@ -138,6 +133,13 @@ A "GitHub Community" section with 1-2 sentences explaining:
- Build professional connections beyond the classroom
- Stay updated on classmates' work for future collaboration

## GitHub Community

Starring repositories helps developers bookmark useful projects and shows support for maintainers. Popular repositories with many stars are often easier to discover and have stronger community engagement.

Following developers helps me learn from their work, discover new projects, and stay informed about updates in technologies that interest me. It also makes collaboration easier in team environments and helps build a professional network.


</details>

---
Expand Down