chore: bump @metamask/* dependencies#585
Merged
Merged
Conversation
Update production @metamask/* dependencies to the latest available versions and migrate tests/helpers.ts off providerFromEngine (removed in @metamask/eth-json-rpc-provider 6.0) to use InternalProvider.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring alerts on:
|
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
Author
|
@SocketSecurity ignore npm/@metamask/transaction-controller@65.4.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps production
@metamask/*dependencies to the latest versions available in the core monorepo. All changelogs were reviewed for breaking changes; the only required code change was migratingtests/helpers.tsoff the removedproviderFromEngine(eth-json-rpc-provider@6.0) toInternalProvider.Dependencies bumped
@metamask/base-controller@metamask/controller-utils@metamask/eth-json-rpc-provider@metamask/messenger@metamask/network-controller@metamask/polling-controller@metamask/profile-sync-controller@metamask/remote-feature-flag-controller@metamask/transaction-controllerBreaking changes reviewed
controller-utils12.0 —ServicePolicy.onDegradedpayload changed; not subscribed in STX.eth-json-rpc-provider5.0 / 6.0 —'data'event removed (unused);providerFromEngineremoved — replaced intests/helpers.tswithnew InternalProvider({ engine }).network-controller31.0 / 32.0 — Event payload additions (not subscribed); default networks pruned (no STX code impact).transaction-controller65.0 — Requires clients to addKeyringController:getStateto the TransactionController messenger's allowed actions. STX only consumes TransactionController actions, so no STX-side change is needed; downstream consumers (mobile/extension) will already handle this.yarn dedupewas run to consolidate@metamask/json-rpc-engineto a single resolution.Test plan
yarn test(jest + attw) passes — 196 testsyarn lintpasses (pre-existing warnings only)Note
Medium Risk
Primarily dependency upgrades across core controller packages; risk comes from pulling in new major versions (e.g.,
@metamask/controller-utils,@metamask/eth-json-rpc-provider) that can subtly change runtime behavior despite minimal local code changes.Overview
Updates the project to newer
@metamask/*package versions (notably@metamask/controller-utils^12.1.0,@metamask/eth-json-rpc-provider^6.0.1, and@metamask/transaction-controller^65.4.0), with correspondingyarn.lockresolution changes.Adjusts
tests/helpers.tsto stop using the removedproviderFromEnginehelper and instead construct anInternalProvideraround aJsonRpcEngine. TheCHANGELOG.mdUnreleased section is updated to record the dependency bumps.Reviewed by Cursor Bugbot for commit 54ed3b0. Bugbot is set up for automated code reviews on this repo. Configure here.