Skip to content

ci: update OFED version to doca3.3.4-26.01-2.0.0.0.719-0 - #3614

Closed
nvidia-ci-cd wants to merge 1 commit into
masterfrom
ci/update-ofed-version-26.01-2.0.0.0.719-0
Closed

nvidia-ci-cd wants to merge 1 commit into
masterfrom
ci/update-ofed-version-26.01-2.0.0.0.719-0

Conversation

@nvidia-ci-cd

Copy link
Copy Markdown
Collaborator

Created by an internal DOCA CI job.

Signed-off-by: svc-cloud-orch-ci <svc-cloud-orch-ci@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Oct 30, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@greptile-apps

greptile-apps Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 3/5

[Medium impact] The version change reaches OFED driver selection in examples and release configuration.

Fix the webhook rejection and driver-check parser before merging.

Findings

  1. P1 Webhook rejects the new version ▶
  2. P1 Driver check selects wrong manifest ▶

Summary

Changes the driver version to doca3.3.4-26.01-2.0.0.0.719-0 in seven example policies and both driver entries in hack/release.yaml.

  • Sample policies and release defaults now use OFED driver version doca3.3.4-26.01-2.0.0.0.719-0.

Reviews (1) · Last reviewed commit: "ci: update OFED version to doca3.3.4-26...." · Reviewed by Greptile

image: doca-driver
repository: nvcr.io/nvstaging/mellanox
version: doca3.6.0-26.10-065000-0
version: doca3.3.4-26.01-2.0.0.0.719-0

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Webhook rejects the new version

With webhook validation enabled, all seven changed example policies are rejected on spec.ofedDriver.version. The DOCA pattern in isValidOFEDVersion accepts four dot-separated numbers before the final dash, but 2.0.0.0.719-0 has five.

Extend the validator to accept this format and add a test for the exact new version before switching the examples.

Comment thread hack/release.yaml
image: doca-driver
repository: nvcr.io/nvstaging/mellanox
version: doca3.6.0-26.10-065000-0
version: doca3.3.4-26.01-2.0.0.0.719-0

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Driver check selects wrong manifest

Changing Mofed.version to doca3.3.4-… breaks make check-doca-drivers. The prefix-removal pattern in Makefile:483 requires the DOCA patch number to be 0, so it leaves this version unchanged. The next split sets DRIVERVERSION to doca3.3.4 instead of 26.01, causing the target to request the wrong release manifest.

Update the parser to accept nonzero patch numbers, or use the second dash-separated field as the release workflow already does.

@rollandf rollandf closed this Oct 31, 2026
@github-actions
github-actions Bot deleted the ci/update-ofed-version-26.01-2.0.0.0.719-0 branch November 2, 2026 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants