feat: Remove profile dynamic container declarations EXO-89538

[MayTekayaa]

Prior to this change, gamification injected ProfileStats, BadgesOverview and ConnectorUserProfile into the profile page through the profile-right-container dynamic container. This change will remove those three declarations, so BadgesOverview and ConnectorUserProfile are declared directly in the profile page definition in the meeds repository (Meeds-io/meeds#4281, <portlet-application profiles="gamification">) and ProfileStats leaves the profile page (it stays registered in portlet.xml and the application registry; where its weekly points and rank resurface is PO deferred item 3 of the spec).

Part of eXIP 7.3.0.18 "User Spaces List" (Tribe note 50524). Release order: wave 3 with Meeds-io/kudos#628, after Meeds-io/social#6085 and Meeds-io/analytics#446, and before Meeds-io/meeds#4281.

Knowledge: none — configuration deletion; the page rewrite it belongs to is documented by Meeds-io/eng-standards#30.

Classification: N1 for the delivery as a whole (max-severity aggregation from Meeds-io/social#6085) — must not merge independently of that classification; Architect/Senior Developer validation, author ≠ approver, no auto-merge on AI review alone.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[boubaker]

AI review — Round #1

Part of the cross-repo review of eXIP 7.3.0.18 "User Spaces List" (Tribe note 50524, revision 6) across Meeds-io/social#6085, Meeds-io/analytics#446, Meeds-io/meeds#4281, Meeds-io/kudos#628 and Meeds-io/gamification#2002, reviewed as one delivery. First round, so there is no status table.

No findings on this PR. Posting the confirmation rather than nothing, so the coherence check is on the record.

Verified: exactly three AddOnPluginImpl declarations are removed and all three targeted profile-right-container — gamification-portlets/ProfileStats (priority 1), gamification-portlets/BadgesOverview (priority 10, whose object-param is confusingly named ProfileStats while its contentId is BadgesOverview — worth knowing if anyone greps by name later) and gamification-portlets/ConnectorUserProfile (priority 20). Nothing targeting another container was removed by accident, and the other addPlugin blocks in the file are untouched.

That matches Meeds-io/meeds#4281 one for one: BadgesOverview and ConnectorUserProfile are re-declared in the profile page as <portlet-application profiles="gamification"> with application-ref = gamification-portlets, so they survive the page re-import — board story US08 — while ProfileStats is deliberately re-declared nowhere and leaves the profile page, per the spec. The portlet itself stays registered in portlet.xml and gatein-resources.xml, so it remains available in the application registry; it is simply on no page.

One thing this leaves open, for the PO rather than for this PR: removing ProfileStats also removes weekly points, weekly rank and the gamification ranking on the card's flip side from the profile page. The spec records that as accepted, but PO deferred item 3 — recording where those surfaces resurface — is still open, and nothing in this delivery closes it.

Release order: wave 3 with Meeds-io/kudos#628, behind social and analytics and before Meeds-io/meeds#4281.

Classification: N1 for the delivery as a whole — max-severity aggregation from Meeds-io/social#6085. This PR's own diff is a configuration deletion, but it must not be merged independently of that classification: validation by an Architect/Senior Developer who knows the delivery is N1, not auto-merge on AI review alone, and author != approver.

Process: the body carries no Knowledge: line, which dev-lifecycle.md §3b step 5 gates at the feature/mips integration PR.

🤖 Generated with Claude Code

[MayTekayaa]

AI review — Round #2 (follow-up)

Part of the cross-repo review of eXIP 7.3.0.18 "User Spaces List" (Tribe note 50524, revision 6) across Meeds-io/social#6085, Meeds-io/analytics#446, Meeds-io/meeds#4281, Meeds-io/kudos#628 and Meeds-io/gamification#2002. Head 6e371f9aa — rebased over feature/mips since round 1; the PR's single file is byte-identical to the round-1 content (the leaderboard changes visible in a merge-base diff belong to another PR already on the branch).

#	Item	Status
1	Process — no Knowledge: line in the body	❌ Still open — dev-lifecycle.md §3b step 5 gates it at the feature/mips integration PR. Knowledge: none — configuration deletion; the page rewrite it belongs to is documented by Meeds-io/eng-standards#30 would do.

No new findings. Re-verified: exactly three AddOnPluginImpl declarations removed, all targeting profile-right-container — ProfileStats (leaves the profile page, stays registered in portlet.xml:44), BadgesOverview and ConnectorUserProfile (re-declared by Meeds-io/meeds#4281 under profiles="gamification" with application-ref = gamification-portlets, portlet.xml:117 and :285). The gamification profile is the add.profiles value of this WAR's META-INF/exo-conf/configuration.xml — its gamification-portlets string there is the container dependency, not the profile, so the page cells match.

Still open for the PO, not for this PR: deferred item 3 — where weekly points, weekly rank and the ranking removed with ProfileStats resurface, if anywhere.

Release order: wave 3 with Meeds-io/kudos#628, after social and analytics and before Meeds-io/meeds#4281.

Classification: N1 for the delivery as a whole (max-severity aggregation from Meeds-io/social#6085); this configuration deletion must not merge independently of that classification — Architect/Senior Developer validation, author != approver, no auto-merge on AI review alone.

🤖 Generated with Claude Code

[MayTekayaa]

Self-review close-out — Meeds-io/kudos#628 (head 3744a4cf) / #2002 (head 6e371f9aa)

Part of the cross-repo self-review of eXIP 7.3.0.18 (Tribe note 50524, board 8368). No code findings in any round. Verified in the closing round: kudos removes exactly the kudos/KudosOverview contribution to profile-right-container; gamification removes exactly ProfileStats, BadgesOverview and ConnectorUserProfile on the same container; BadgesOverview, ConnectorUserProfile and KudosOverview are re-declared by Meeds-io/meeds#4281 under profiles="gamification" / "kudos" (US08); ProfileStats stays registered in portlet.xml and leaves the profile page; nothing else in either repo references any of the seven dropped containers. Process item (the Knowledge: line) is now in the body.

Release order: wave 3, after social and analytics, before Meeds-io/meeds#4281.

Classification: N1 for the delivery as a whole (max-severity aggregation from Meeds-io/social#6085); these configuration deletions must not merge independently of that classification — Architect/Senior Developer validation, author ≠ approver, no auto-merge on AI review alone.

🤖 Generated with Claude Code

[boubaker]

AI review — Round #2 (follow-up)

Head unchanged at 6e371f9aa. The only round-1 item was the missing Knowledge: line — ✅ now in the body (none — configuration deletion, pointing at Meeds-io/eng-standards#30, which is merged). No new findings; nothing outstanding on this PR from the AI review side. Release order: wave 3, before Meeds-io/meeds#4281.

Classification: N1 for the delivery as a whole (max-severity aggregation from Meeds-io/social#6085) — must not merge independently of that classification; Architect/Senior Developer validation, author != approver, no auto-merge on AI review alone.

🤖 Generated with Claude Code

[MayTekayaa]

AI review — Round #3 (final)

Part of the cross-repo review of eXIP 7.3.0.18 "User Spaces List" (Tribe note 50524, revision 6) across Meeds-io/social#6085, Meeds-io/analytics#446, Meeds-io/meeds#4281, Meeds-io/kudos#628 and Meeds-io/gamification#2002.

Round	#	Item	Status
2	1	Process — Knowledge: line in the body	✅ Fixed — Knowledge: none — configuration deletion; … Meeds-io/eng-standards#30

No code finding in any round. The PR's single file is unchanged since round 1 (gamification was rebased twice, content byte-identical). Re-verified in round 2: the removed AddOnPluginImpl declarations target profile-right-container only, and the portlets that stay on the profile page are re-declared by Meeds-io/meeds#4281 under the addon's own add.profiles value (US08).

All findings from previous rounds are resolved; nothing outstanding from the AI review side.

Release order: wave 3, after Meeds-io/social#6085 and Meeds-io/analytics#446, before Meeds-io/meeds#4281.

Classification: N1 for the delivery as a whole (max-severity aggregation from Meeds-io/social#6085); this configuration deletion must not merge independently of that classification — Architect/Senior Developer validation, author != approver, no auto-merge on AI review alone.

🤖 Generated with Claude Code