Repository navigation
Conversation
zt64
suggested changes
Jul 15, 2025
| - name: Download Schema via Introspection | ||
| run: | | ||
| chmod +x ./gradlew && ./gradlew :api:downloadServiceApolloSchemaFromIntrospection | ||
| chmod +x ./gradlew |
Contributor
There was a problem hiding this comment.
You dont need to run chmod +x gradlew. It already has executable flag set
|
|
||
| import com.apollographql.apollo.api.Optional | ||
|
|
||
| fun <T> T?.toOptional(): Optional<T> = Optional.presentIfNotNull(this) No newline at end of file |
Member
Author
There was a problem hiding this comment.
i get yelled at for it not having significant performance benefits
| rootProject.name = "Gloom" | ||
| include(":app") | ||
|
|
||
| enableFeaturePreview("TYPESAFE_PROJECT_ACCESSORS") |
Contributor
There was a problem hiding this comment.
I think this should be at the very top, since it's enabling a global feature
| @@ -9,8 +10,19 @@ pluginManagement { | |||
| rootProject.name = "Gloom" | |||
| include(":app") | |||
- Switch to jvmToolchain - Allow using existing plugin declarations from version catalog as compileOnly
Also minor fragment changes
WARNING: Only gradle sync was tested, building probably fails
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.