Repository navigation
prevent path traversal via icon names - #995
Merged
MalpenZibo merged 1 commit intoOct 1, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@MalpenZibo
Add
is_safe_icon_namevalidation to reject icon names containing..,/, or null bytes before they reachfreedesktop_icons, whichjoins them onto a base path. Absolute names and
..sequences couldotherwise escape the icon directory. Single dots remain allowed since
they are valid in reverse-DNS names. Includes unit tests covering
traversal attempts, separators, and null bytes.
I also want to take a deeper look at #970 I think we might need some to check this thoroughly.
Next week I might have some time to finish some of my started branches and some more code reviews.