Repository navigation
Conversation
|
Thanks @sulabi , you spotted a real problem! With #1029 alone, [appearance.modules.system_info] is silently ignored. I'd rather fix it directly in #1029 though, because changing ModuleName has side effects I'd like to avoid:
In the end I'd like to have this syntax: [system_info] # module settings
[appearance.modules.system_info] # module style: same nameCustom modules need their own namespace. In the settings a custom module can't clash with a builtin, because builtins have their own section and custom modules live in [custom_modules.appLauncher]
command = "walker"
[appearance.modules.custom.appLauncher]
background = "primary"So I think that we can close this PR and fix #1029. The custom module changes should go in a dedicated PR instead. @romanstingler, what do you think? |
|
yeah, this works for me |
Restore snake_case module names. Follow up of #1029