Skip to content

Rename Nova++ to HERACLES++ #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tpadioleau merged 1 commit into from
Dec 5, 2025
Merged

Rename Nova++ to HERACLES++ #199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions .github/workflows/tests-macos.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ concurrency:
env:
CMAKE_BUILD_TYPE: Release
CMAKE_GENERATOR: Ninja
NOVAPP_DEFAULT_DEPENDENCY_POLICY: INSTALLED
HERACLESPP_DEFAULT_DEPENDENCY_POLICY: INSTALLED

jobs:
build-serial-3d:
Expand Down Expand Up @@ -115,12 +115,12 @@ jobs:
cmake \
-D BUILD_TESTING=ON \
-D CMAKE_COMPILE_WARNING_AS_ERROR=ON \
-D Novapp_BUILD_BENCHMARKING=ON \
-D Novapp_EOS=PerfectGas \
-D Novapp_GEOM=Cartesian \
-D Novapp_GRAVITY=Uniform \
-D Novapp_SETUP=advection_sinus \
-D Novapp_NDIM=3 \
-D Heraclespp_BUILD_BENCHMARKING=ON \
-D Heraclespp_EOS=PerfectGas \
-D Heraclespp_GEOM=Cartesian \
-D Heraclespp_GRAVITY=Uniform \
-D Heraclespp_SETUP=advection_sinus \
-D Heraclespp_NDIM=3 \
-B build
cmake --build build
ctest --test-dir build --output-on-failure --timeout 5 --output-junit tests.xml
Expand Down
110 changes: 55 additions & 55 deletions .github/workflows/tests-ubuntu.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ env:
CMAKE_BUILD_PARALLEL_LEVEL: 4
CMAKE_BUILD_TYPE: Release
CMAKE_GENERATOR: Ninja
NOVAPP_DEFAULT_DEPENDENCY_POLICY: INSTALLED
HERACLESPP_DEFAULT_DEPENDENCY_POLICY: INSTALLED

jobs:
cpp-format:
Expand Down Expand Up @@ -237,12 +237,12 @@ jobs:
cmake \
-D BUILD_TESTING=ON \
-D CMAKE_COMPILE_WARNING_AS_ERROR=ON \
-D Novapp_BUILD_BENCHMARKING=ON \
-D Novapp_EOS=PerfectGas \
-D Novapp_GEOM=Cartesian \
-D Novapp_GRAVITY=Uniform \
-D Novapp_NDIM=1 \
-D Novapp_SETUP=advection_sinus \
-D Heraclespp_BUILD_BENCHMARKING=ON \
-D Heraclespp_EOS=PerfectGas \
-D Heraclespp_GEOM=Cartesian \
-D Heraclespp_GRAVITY=Uniform \
-D Heraclespp_NDIM=1 \
-D Heraclespp_SETUP=advection_sinus \
-B build
cmake --build build
ctest --test-dir build --output-on-failure --timeout 5 --output-junit tests.xml
Expand Down Expand Up @@ -282,12 +282,12 @@ jobs:
cmake \
-D BUILD_TESTING=ON \
-D CMAKE_COMPILE_WARNING_AS_ERROR=ON \
-D Novapp_BUILD_BENCHMARKING=ON \
-D Novapp_EOS=PerfectGas \
-D Novapp_GEOM=Cartesian \
-D Novapp_GRAVITY=Uniform \
-D Novapp_NDIM=2 \
-D Novapp_SETUP=advection_sinus \
-D Heraclespp_BUILD_BENCHMARKING=ON \
-D Heraclespp_EOS=PerfectGas \
-D Heraclespp_GEOM=Cartesian \
-D Heraclespp_GRAVITY=Uniform \
-D Heraclespp_NDIM=2 \
-D Heraclespp_SETUP=advection_sinus \
-B build
cmake --build build
ctest --test-dir build --output-on-failure --timeout 5 --output-junit tests.xml
Expand Down Expand Up @@ -324,12 +324,12 @@ jobs:
cmake \
-D BUILD_TESTING=ON \
-D CMAKE_COMPILE_WARNING_AS_ERROR=ON \
-D Novapp_BUILD_BENCHMARKING=ON \
-D Novapp_EOS=PerfectGas \
-D Novapp_GEOM=Cartesian \
-D Novapp_GRAVITY=Uniform \
-D Novapp_NDIM=3 \
-D Novapp_SETUP=advection_sinus \
-D Heraclespp_BUILD_BENCHMARKING=ON \
-D Heraclespp_EOS=PerfectGas \
-D Heraclespp_GEOM=Cartesian \
-D Heraclespp_GRAVITY=Uniform \
-D Heraclespp_NDIM=3 \
-D Heraclespp_SETUP=advection_sinus \
-B build
cmake --build build
ctest --test-dir build --output-on-failure --timeout 5 --output-junit tests.xml
Expand Down Expand Up @@ -365,12 +365,12 @@ jobs:
cmake \
-D BUILD_TESTING=ON \
-D CMAKE_CXX_EXTENSIONS=OFF \
-D Novapp_BUILD_BENCHMARKING=ON \
-D Novapp_EOS=PerfectGas \
-D Novapp_GEOM=Cartesian \
-D Novapp_GRAVITY=Uniform \
-D Novapp_NDIM=3 \
-D Novapp_SETUP=advection_sinus \
-D Heraclespp_BUILD_BENCHMARKING=ON \
-D Heraclespp_EOS=PerfectGas \
-D Heraclespp_GEOM=Cartesian \
-D Heraclespp_GRAVITY=Uniform \
-D Heraclespp_NDIM=3 \
-D Heraclespp_SETUP=advection_sinus \
-B build
cmake --build build

Expand Down Expand Up @@ -398,12 +398,12 @@ jobs:
cmake \
-D BUILD_TESTING=ON \
-D CMAKE_COMPILE_WARNING_AS_ERROR=ON \
-D Novapp_BUILD_BENCHMARKING=ON \
-D Novapp_EOS=PerfectGas \
-D Novapp_GEOM=Cartesian \
-D Novapp_GRAVITY=Uniform \
-D Novapp_NDIM=3 \
-D Novapp_SETUP=advection_sinus \
-D Heraclespp_BUILD_BENCHMARKING=ON \
-D Heraclespp_EOS=PerfectGas \
-D Heraclespp_GEOM=Cartesian \
-D Heraclespp_GRAVITY=Uniform \
-D Heraclespp_NDIM=3 \
-D Heraclespp_SETUP=advection_sinus \
-B build
cmake --build build

Expand Down Expand Up @@ -439,12 +439,12 @@ jobs:
-D BUILD_TESTING=ON \
-D CMAKE_CXX_COMPILER=clang++-21 \
-D CMAKE_CXX_INCLUDE_WHAT_YOU_USE="include-what-you-use;-Xiwyu;--verbose=3;-Xiwyu;--mapping=$PWD/iwyu-heraclespp.json;-Xiwyu;--mapping=$PWD/iwyu-kokkos.json;" \
-D Novapp_BUILD_BENCHMARKING=ON \
-D Novapp_EOS=PerfectGas \
-D Novapp_GEOM=Cartesian \
-D Novapp_GRAVITY=Uniform \
-D Novapp_NDIM=3 \
-D Novapp_SETUP=advection_sinus \
-D Heraclespp_BUILD_BENCHMARKING=ON \
-D Heraclespp_EOS=PerfectGas \
-D Heraclespp_GEOM=Cartesian \
-D Heraclespp_GRAVITY=Uniform \
-D Heraclespp_NDIM=3 \
-D Heraclespp_SETUP=advection_sinus \
-B build
cmake --build build

Expand All @@ -471,12 +471,12 @@ jobs:
-D BUILD_TESTING=ON \
-D CMAKE_CXX_COMPILER=clang++-21 \
-D CMAKE_CXX_CLANG_TIDY="clang-tidy-21;-header-filter=${{github.workspace}}/src/.*;-warnings-as-errors=*" \
-D Novapp_BUILD_BENCHMARKING=ON \
-D Novapp_EOS=PerfectGas \
-D Novapp_GEOM=Cartesian \
-D Novapp_GRAVITY=Uniform \
-D Novapp_NDIM=3 \
-D Novapp_SETUP=advection_sinus \
-D Heraclespp_BUILD_BENCHMARKING=ON \
-D Heraclespp_EOS=PerfectGas \
-D Heraclespp_GEOM=Cartesian \
-D Heraclespp_GRAVITY=Uniform \
-D Heraclespp_NDIM=3 \
-D Heraclespp_SETUP=advection_sinus \
-B build
cmake --build build

Expand All @@ -503,12 +503,12 @@ jobs:
-D BUILD_TESTING=ON \
-D CMAKE_CXX_COMPILER=clang++-21 \
-D CMAKE_LINK_WHAT_YOU_USE=ON \
-D Novapp_BUILD_BENCHMARKING=ON \
-D Novapp_EOS=PerfectGas \
-D Novapp_GEOM=Cartesian \
-D Novapp_GRAVITY=Uniform \
-D Novapp_NDIM=3 \
-D Novapp_SETUP=advection_sinus \
-D Heraclespp_BUILD_BENCHMARKING=ON \
-D Heraclespp_EOS=PerfectGas \
-D Heraclespp_GEOM=Cartesian \
-D Heraclespp_GRAVITY=Uniform \
-D Heraclespp_NDIM=3 \
-D Heraclespp_SETUP=advection_sinus \
-B build
cmake --build build

Expand All @@ -534,11 +534,11 @@ jobs:
cmake \
-D BUILD_TESTING=OFF \
-D DOXYGEN_WARN_AS_ERROR=YES \
-D Novapp_BUILD_BENCHMARKING=OFF \
-D Novapp_EOS=PerfectGas \
-D Novapp_GEOM=Cartesian \
-D Novapp_GRAVITY=Uniform \
-D Novapp_NDIM=3 \
-D Novapp_SETUP=advection_sinus \
-D Heraclespp_BUILD_BENCHMARKING=OFF \
-D Heraclespp_EOS=PerfectGas \
-D Heraclespp_GEOM=Cartesian \
-D Heraclespp_GRAVITY=Uniform \
-D Heraclespp_NDIM=3 \
-D Heraclespp_SETUP=advection_sinus \
-B build
cmake --build build --target doxygen
Loading