Repository navigation
Add Remapper.prepare_map() and update to 2.5.0 - #191
Merged
Merged
Conversation
prepare_map() writes the SCRIP files (and, for MOAB, converts and partitions them for ntasks) and returns the mapping tool's command line without running it or putting a parallel launcher in front of it. This is for workflows such as Polaris that launch MPI jobs themselves, with their own launcher flags and placement. build_map() now uses the same code to write the files and get the command, then launches it as before. With use_tmp, the temporary directory is now removed even if the mapping tool fails. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Collaborator
Author
Testing
Posted by Claude Code on @xylar's behalf. The testing, analysis and wording above are AI-authored; please check them accordingly. |
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds
Remapper.prepare_map(), which writes the files the mapping tool reads (the SCRIP files and, for MOAB, their HDF5 conversion and partitioning) and returns the tool's command line without running it or putting a parallel launcher in front of it. Polaris needs this to launch the mapping tool itself, with its own launcher flags and placement (E3SM-Project/polaris#875).build_map()now uses the same code.It also updates the version to 2.5.0.
Posted by Claude Code on @xylar's behalf. The testing, analysis and wording above are AI-authored; please check them accordingly.