Repository navigation
Conversation
Remove filter that ensures the intiial condition has the same file name base as the forcing files. This is overly restrictive, since there can be many initial condition files with the same geometry.
Setup re-read a nonexistent sea_level_model config option after parsing gia_model, which turned off the SLM namelist and config_uplift_method whenever gia_model = 1dSLM. Remove that line. Also: * Set the SLM starttime to the start year of the experiment's historical run rather than a hard-coded 2000. * Copy OUTPUT_SLM and ICELOAD_SLM from the historical run when a projection or ctrl experiment is run, so the SLM can restart with its full history. Directories that already have contents are left alone. * Document the SLM start year and restart behavior. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes
gia_model = 1dSLMinlandice/ismip7_run/ismip7_ais, which previously set up runs with no SLM namelist andconfig_uplift_method = 'none'. The cause was a leftoversea_level_modelconfig lookup, fromismip6_run, that overrode thegia_modelsetting.Changes:
starttimenow matches the start year of the experiment's historical run (2008) instead of a hard-coded 2000.OUTPUT_SLMandICELOAD_SLMfrom their historical run when they are run, so the SLM can restart with its full history. This replaces the manual copy thatismip6_runrequires. Directories that already have contents are left alone, and a clear error is raised if the historical run has not produced them.For review:
starttime, because they restart with the historical SLM history. Please confirm this is what the SLM expects.ocxis treated as a historical-type run, so it also runs with the SLM whengia_model = 1dSLM.Checklist
Testingin this PR) any testing that was used to verify the changes