Conversation
add png update electron for wayland add appimage support initial nsis windows support
updated build to make an nsis installer updated icon to support multires on windows
update to latest checkout and setup-node
Changing actions workflow to allow building on release old work flow only worked on push of updates that contains a tag and a commit with the same version number though git cli
forgot to run the modified npm build command
Author
|
it runs and claims connections, but it aint oscing, atleast on linux, binaries are on my fork |
Author
|
so it looks to be an osc and oscquery mdns issue |
Collaborator
|
Heads up — this PR overlaps with the auto-update tracking issues, specifically #38 (Phase A: CI workflow + GitHub Releases manifest). A few things worth aligning before merging: Version delta vs the auto-update plan:
Publisher choice:
Linux target:
NetApp file:
Worth either resolving these against #38 before merging, or coordinating a merge order so #38 lands first and adjusts to the new electron-builder version. Either works — just don't want both to land and then need an emergency electron-updater pin bump. Cross-referenced from #38 (Phase A). |
8 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created a action workflow for building windows and linux binaries/installers
Changes
New with actions file
I tried using electron-builder's built in publisher tool. but i could not get it to work properly so it builds with
--publish=neverand a different action handles publishing it