Skip to content

fix: Multiple read clusters liveview component for ClickHouse backends - #3821

Open
amokan wants to merge 5 commits into
mainfrom
adammokan/o11y-2312-fix-ux-for-clickhouse-multiple-read-clusters
Open

fix: Multiple read clusters liveview component for ClickHouse backends#3821
amokan wants to merge 5 commits into
mainfrom
adammokan/o11y-2312-fix-ux-for-clickhouse-multiple-read-clusters

Conversation

@amokan

@amokan amokan commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Fixes the most pressing issues with the LogflareWeb.Backends.ReadClusterUrlsComponent LiveView component.

Usability fixes coming after this merges

@amokan amokan changed the title fix: clickhouse adaptor support for multiple read clusters fix: Multiple read clusters liveview component for ClickHouse backends Aug 12, 2026
@amokan
amokan marked this pull request as ready for review August 12, 2026 17:51
@amokan
amokan requested a review from djwhitt August 12, 2026 17:52
@djwhitt

djwhitt commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

🤖

test/logflare_web/live/backends/backends_live_test.exs:700 derives row order with Map.to_list/1, while ReadClusterUrlsComponent now sorts read_only_urls by label. Map enumeration order is not guaranteed. Sort the entries using the component’s ordering before selecting the first and last labels.

@djwhitt

djwhitt commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

🤖

Add follow-up browser coverage in test/e2e/features/backends_test.exs that edits an existing row and fills a newly added row before a component rerender, then verifies that the values remain. Include a failed-save path to cover value preservation across error rerenders. This is non-blocking for the current state-reset fix.

amokan and others added 3 commits August 12, 2026 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants