fix(syslog): fix possible socket leak in the pool - #3810
Merged
Conversation
ruslandoga
commented
Aug 11, 2026
| Mimic.copy(Logflare.Backends.Adaptor.ClickHouseAdaptor.ConnectionManager) | ||
| Mimic.copy(Logflare.Backends.Adaptor.HttpBased.Client) | ||
| Mimic.copy(Logflare.Backends.Adaptor.SlackAdaptor.Client) | ||
| Mimic.copy(Logflare.Backends.Adaptor.SyslogAdaptor.Socket) |
Contributor
Author
There was a problem hiding this comment.
I'm not sure how best to test it since we are not waiting for anything during Socket.send/2 so we can't properly time the process exit.
ruslandoga
changed the title
Ziinc
approved these changes
Aug 17, 2026
Ziinc
left a comment
Ziinc
left a comment
Contributor
There was a problem hiding this comment.
testing logic looks fine to me 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a Syslog socket leak when the borrower dies after opening and transferring a connection but before check-in. It's probably quite unlikely (why would a broadway worker just die during
Pool.send/2) but probably still worth doing.