fix(node): accept plain slot hash inputs - #400
Merged
Merged
Conversation
xternet
marked this pull request as ready for review
August 13, 2026 19:41
Collaborator
|
Thank you for the fix |
Aursen
approved these changes
Aug 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #178.
TypeScript accepts a structural
{ slot, hash }value forsetSlotHashes, but the native method previously required references to the NAPISlotHashclass. At runtime, a plain object therefore failed withFailed to recover SlotHash type from napi value.Add a setter-only
SlotHashInputNAPI object and accept that input in the native setter. The existingSlotHashNAPI class is deliberately preserved for getter results and runtime compatibility.Compatibility
SlotHashremains an exported runtime class.getSlotHashes()continues to returnSlotHashinstances.SlotHashinstances remain structurally valid setter inputs.{ slot, hash }object literals now work as the public TypeScript signature implies.Regression test
The new test passes an object literal to
setSlotHashes, checks the values returned bygetSlotHashes, and asserts that the returned value is stillinstanceof SlotHash.Validation
yarn build:jsyarn lint:jscargo test -p litesvm-nodecargo clippy -p litesvm-node --all-targetscargo +nightly fmt --all -- --checkgit diff --check