Project.swift: upgrade deployment target from iOS 13 to 15.#35
Merged
Conversation
Noam Freeman (noamfreeman)
requested a review
from Dekel Avrahami (DekelAvrahami)
Member
|
First commit LGTM. Is the second commit intentionally added? either remove it or explain. |
Member
Author
|
removing second. |
Noam Freeman (noamfreeman)
force-pushed
the
xcode27
branch
from
5077ff7 to
b1c93c8
Compare
Noam Freeman (noamfreeman)
merged commit b509a82
into
lightricks-nimble/13.6.0
2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To build in xcode27, we need a minimum deployment target of iOS 15.
the latest release from quick/nimble, is still on 13.
to see it on foundations CI: https://github.com/Lightricks/Foundations/pull/11700