Fix CMake installer resource path - #3
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CMake release build still failed while compiling the installer resource because
installer/artpicst_installer.rcreferenced the icon with a source-relative path that was resolved from the generated build directory.This change makes the CMake path deterministic by configuring a generated installer resource script with the absolute, forward-slash path to
resources/artpicst.ico. Manual batch and PowerShell builds continue using the existing source resource script.git diff --checkpasses. Native CMake/MSVC compilation could not be run locally because this environment does not include CMake, MSVC, orrc.exe.