feat: policy signature flow#7518
Draft
vitormattos wants to merge 1122 commits intomainfrom
Draft
Conversation
vitormattos
force-pushed
the
feat/policy-signature-flow-phase1-groundwork
branch
2 times, most recently
from
955dec8 to
2b5c509
Compare
vitormattos
force-pushed
the
feat/policy-signature-flow-phase1-groundwork
branch
3 times, most recently
from
e0949a0 to
e843d15
Compare
vitormattos
force-pushed
the
feat/policy-signature-flow-phase1-groundwork
branch
3 times, most recently
from
d015bfa to
3742c49
Compare
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
…oller Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
When an instance admin removes the only rule for groups_request_sign, the frontend sends value=null via setSystem. The guard was treating null as an empty group list and returning 400 with 'At least one authorized group is required'. Add allowNullReset parameter (default false) so only setSystem (the delete-rule path) passes true, allowing the reset to flow through to PolicyService.saveSystem which then falls back to the default admin group. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Instance admin clicking Remove on the last groups_request_sign rule triggers setSystem with value=null. Pass allowNullReset=true to normalizeManagedValue so the null propagates correctly instead of returning 400. Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
…se when supportsUserPreference() is false Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
…sUserPreference() Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
…finition.ts Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
…algorithm/SignatureHashAlgorithmRuleEditor.vue Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
…algorithm/model.ts Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
…algorithm/realDefinition.ts Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
…eature Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
…icyTest.php Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
…idationPolicyTest.php Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
…faultUserFolderPolicyTest.php Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
…icyTest.php Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
…rationRulesPolicyTest.php Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
…alInformationPolicyTest.php Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
…icyTest.php Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
…hm/SignatureHashAlgorithmPolicyTest.php Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
…formation, identify_methods) Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
- Reorder AEngineHandler::setEngine() to save policy before persisting engine to appConfig; if policy save fails, engine is not changed - Remove try/catch from configureIdentifyMethodsForEngine() so failures propagate instead of being logged and ignored - Remove try/catch from AbstractIdentifyMethod::getRuntimeConfigInt() so programming errors (unknown policy keys) propagate rather than silently returning defaults Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
…s in realDefinition Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
vitormattos
force-pushed
the
feat/policy-signature-flow-phase1-groundwork
branch
from
85e7eb3 to
31cf1a8
Compare
…ad typing Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
Signed-off-by: Vitor Mattos <1079143+vitormattos@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.