Fix symbol conflict by hiding bundled TurboJPEG symbols - #737
Open
M3ML1NE wants to merge 1 commit into
Open
Conversation
M3ML1NE
force-pushed
the
fix/auto-bounty-729
branch
from
August 12, 2026 10:27
a05fd6e to
c511243
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #729
Summary
When an application links to both libvncserver (or libvncclient) and external libjpeg-turbo, symbol collisions occur because libvncserver exports bundled tjCompress2, tjDecompress2, etc., without hidden visibility on GCC/Clang.
Fix
Defined DLLEXPORT as
__attribute__ ((visibility ("hidden")))on GCC/Clang (>=4) insrc/common/turbojpeg.hso bundled TurboJPEG symbols remain internal to libvncserver and do not conflict with external libjpeg-turbo symbols linked by applications.