[lua] mobMagicalMove Clean Up + Alpha Multiplier Support. - #11371
Merged
Xaver-DaRed merged 1 commit intoSep 9, 2026
Conversation
UmeboshiXI
force-pushed
the
mobskill_alpha_multiplier
branch
3 times, most recently
from
September 3, 2026 01:52
7941028 to
38d8031
Compare
UmeboshiXI
marked this pull request as draft
September 4, 2026 16:30
Contributor
Author
|
Going to make some adjustments after thinking about this more. Update: Eliminated mobskill params relating to alpha. Made it so if an wSC param exists on a weaponskill/mobskill, then it will automatically apply alpha if applicable when wSCs are being calculated. |
UmeboshiXI
force-pushed
the
mobskill_alpha_multiplier
branch
2 times, most recently
from
September 4, 2026 17:02
6659118 to
a32086e
Compare
UmeboshiXI
marked this pull request as ready for review
September 4, 2026 17:06
Xaver-DaRed
reviewed
Sep 5, 2026
UmeboshiXI
force-pushed
the
mobskill_alpha_multiplier
branch
from
September 5, 2026 19:14
a32086e to
e0225c5
Compare
WinterSolstice8
approved these changes
Sep 7, 2026
Xaver-DaRed
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
xi.combat.physicaland applies it withinxi.combat.physical.calculateWSC().USE_ADOULIN_WEAPON_SKILL_CHANGESis set to true.USE_ADOULIN_WEAPON_SKILL_CHANGESis false, then the alpha level scaling will be applied to wSC multipliers.Steps to test these changes
USE_ADOULIN_WEAPON_SKILL_CHANGESis set to false.