Skip to content

[lua] mobMagicalMove Clean Up + Alpha Multiplier Support. - #11371

Merged
Xaver-DaRed merged 1 commit into
LandSandBoat:basefrom
UmeboshiXI:mobskill_alpha_multiplier
Sep 9, 2026
Merged

[lua] mobMagicalMove Clean Up + Alpha Multiplier Support.#11371
Xaver-DaRed merged 1 commit into
LandSandBoat:basefrom
UmeboshiXI:mobskill_alpha_multiplier

Conversation

@UmeboshiXI

@UmeboshiXI UmeboshiXI commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

  1. Converts mobMagicalMove params to use the same system that exists for physical mobskills.
  2. Removes some enums in mobskills.lua that were flagged for removal.
  3. Migrates alpha calculation to xi.combat.physical and applies it within xi.combat.physical.calculateWSC().
  • Alpha will be 1 if USE_ADOULIN_WEAPON_SKILL_CHANGES is set to true.
  • If USE_ADOULIN_WEAPON_SKILL_CHANGES is false, then the alpha level scaling will be applied to wSC multipliers.

Steps to test these changes

  • You should observe no changes other than support for mobskills to use alpha multipliers when USE_ADOULIN_WEAPON_SKILL_CHANGES is set to false.
  1. Add a wSC mod to a mobskill or simply use a weaponskill.
  2. Have a mob use mobskills or use a weaponskill, see no errors and see that they still do damage.
  3. Turn USE_ADOULIN_WEAPON_SKILL_CHANGES to false in settings and restart server.
  4. Repeat step 1/2. See that the skill will now do lower damage since the wSC mods are being lowered by alpha.

@UmeboshiXI
UmeboshiXI force-pushed the mobskill_alpha_multiplier branch 3 times, most recently from 7941028 to 38d8031 Compare September 3, 2026 01:52
@UmeboshiXI
UmeboshiXI marked this pull request as draft September 4, 2026 16:30
@UmeboshiXI

UmeboshiXI commented Sep 4, 2026

Copy link
Copy Markdown
Contributor Author

Going to make some adjustments after thinking about this more.

Update: Eliminated mobskill params relating to alpha. Made it so if an wSC param exists on a weaponskill/mobskill, then it will automatically apply alpha if applicable when wSCs are being calculated.

@UmeboshiXI
UmeboshiXI force-pushed the mobskill_alpha_multiplier branch 2 times, most recently from 6659118 to a32086e Compare September 4, 2026 17:02
@UmeboshiXI
UmeboshiXI marked this pull request as ready for review September 4, 2026 17:06
Comment thread scripts/globals/mobskills.lua Outdated
@UmeboshiXI
UmeboshiXI force-pushed the mobskill_alpha_multiplier branch from a32086e to e0225c5 Compare September 5, 2026 19:14
@Xaver-DaRed
Xaver-DaRed merged commit ec35167 into LandSandBoat:base Sep 9, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants