Add Armoire Furniture Quest - #11294
Open
TiberonKalkaz wants to merge 1 commit into
Open
Conversation
TiberonKalkaz
force-pushed
the
furniture_quests
branch
2 times, most recently
from
August 28, 2026 07:30
52ad8f6 to
04ebb0f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
Adds Armoire Furniture Quest using the HiddenQuest framework.
I was thinking using the hidden quest framework would reduce the amount of code and manual management compared to how I implemented this on ASB. Overall, the cost of adding a new furniture quest is higher than the ASB version, but each individual furniture quest will be encapsulated to two files.
I could go with either approach - would love some feedback before I run through the other ~14 items and maybe some seasonal items.
Steps to test these changes
Era Notes
Once the approach is settled, I plan to create an era module to set the wait times from 4 mins to next conquest.