[lua] Moves healing spells to new combat framework - #11279
Open
Frankie-hz wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I affirm:
What does this pull request do?
Moves all cure spells into the
xi.combat.actionframework, matching the pattern already used by action_spikes_damage.lua and action_additional_effect luas. Same comment style and everything.This comes with the globalization of healing spells and the removal of even more functions inside magic.lua so we can finally delete it.
Each spell script is now a
cureTierstable plus aparamstable passed toexecuteSpellCureWhite magic:
Blue magic:
Cure I-VI keep the undead-enemy damage branch in the spell script before calling the framework as suggested.
Misc fixes:
target:wakeUp()was removed but addHP actually removed the same three sleep effectsThings left unchanged:
Steps to test these changes
The formula for heals did not actually change so casting and cure spell you should not see any difference from before vs after this PR.
Welcome to white mage fun...
!changejob 3 99(WHM 99)!addallspells!addalltrustsand summon a trust so aoe cures have a second target!hp 1before any cure so the amount is not clamped by missing HPImportant things to test:
Afflatus Solace
!geteffects!additem 11186(Orison Bliaut +1), equip it, repeat step 2. Should be 30%.!additem 11086(Orison Bliaut +2), equip it, repeat step 2. Should be 35%.!addeffect stoneskin 100 60, then cast Cure. The existing Stoneskin should not be replaced.25% of 34 is 8.5 -> floored to 8 /cheer



30% with chest on
No stoneskin on aoe
Target validation
!zone 190Divine Seal and Rapture
!hp 1!hp 1!addeffect rapture(SCH 55 ability, not available on sub). Cast Cure. Amount should be 1.5x and Rapture should be gone from!geteffects.Cure Potency caps
!setmod cure_potency 80. Cast Cure. Bonus should be 50%, not 80%.!setmod cure_potency 0!setmod cure_potency_ii 50. Cast Cure. Bonus should be 30%, not 50%.!setmod cure_potency_ii 0Cure to MP
!setmod cure2mp_percent 10!setmod cure2mp_percent 0MP 107 -> 68 after cure iv cast
Healed for 495 which means 107 - 88mp + 49 = 68mp
Afflatus Misery
First is with it on and getting hit. Second is nothing on
Blue magic
!changejob 16 99(BLU 99)!addallspellsand set Pollen, Wild Carrot, Healing Breeze, Magic Fruit, Exuviation, White Wind, and Plenilune Embrace.!hp 1and cast each one. Amounts should match before this PR.After casting Plenilune Embrace
