Skip to content

[roe] Add Total Successful Harvesting Attempts I and II - #11177

Merged
WinterSolstice8 merged 1 commit into
LandSandBoat:basefrom
JasonW77:fix/roe-harvesting-records
Sep 12, 2026
Merged

WinterSolstice8 merged 1 commit into
LandSandBoat:basefrom
JasonW77:fix/roe-harvesting-records

Conversation

@JasonW77

Copy link
Copy Markdown
Contributor

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Adds missing Records of Eminence objectives 61 and 118 to scripts/globals/roe_records.lua.

  • 61 Total Successful Harvesting Attempts: 300 successes, 2000 sparks / 6000 exp / 200 accolades (2013-12-11).
  • 118 Total Suc. Harvesting Attempts II: repeatable 30 successes, 200 sparks / 600 exp / 20 accolades (2015-01-15).

Sources: XIchecklist RoE dump. Zone Harvesting records already use HELM_SUCCESS without a skillType filter (they include mines/logging zones), so these general records do the same.

Steps to test these changes

  • Set record 61, succeed at harvesting/mining/logging 300 times, confirm completion and rewards.
  • Set record 118, succeed 30 times, confirm it is repeatable.
  • Confirm existing zone Harvesting records still complete as before.

Made with Cursor

@sruon sruon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the Cursor co-author?

Records 61 and 118 were missing from roe_records.lua.
IDs, goals, and rewards match the XIchecklist RoE dump (61: 2013-12-11, 118: 2015-01-15).
No skillType filter: retail general Harvesting objectives count all HELM successes.
@JasonW77
JasonW77 force-pushed the fix/roe-harvesting-records branch from aa6d2de to 30094c1 Compare August 19, 2026 07:02
@JasonW77

Copy link
Copy Markdown
Contributor Author

Removed the Cursor co-author.

@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown

This PR has been automatically marked as stale because
it has not had recent activity. It will be closed if no
further activity occurs.

@github-actions github-actions Bot added the stale label Sep 3, 2026
@WinterSolstice8
WinterSolstice8 merged commit bdf6f83 into LandSandBoat:base Sep 12, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants