Fix/contract logic issues - #1556
Open
emwulrd wants to merge 2 commits into
Open
Conversation
added 2 commits
July 28, 2026 22:31
Fixes LabsCrypt#1493 - The markRead endpoint accepted unbounded ids arrays, allowing clients to submit arbitrarily large arrays that expand into huge SQL IN clauses. Added MAX_IDS_PER_REQUEST constant set to 100, matching the pattern from other batch endpoints. Requests exceeding the cap now return HTTP 400. Empty arrays are handled as no-ops. File: backend/src/controllers/notificationController.ts Function: markRead
Fixes LabsCrypt#1494 - The CodeQL workflow had invalid YAML indentation causing the workflow to never run. Fixed matrix and language entries to nest correctly under strategy, and corrected step indentation. The workflow now parses cleanly and will execute CodeQL scans for both JavaScript/ TypeScript and Rust languages. File: .github/workflows/codeql.yml
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Multiple Critical Issues
Summary
Fixed critical bugs across contracts, backend, and infrastructure.
Issues Addressed
Closes #1493
Closes #1494
Closes #1322
Closes #1317
Changes
Contracts
check_default- loans can no longer be flagged as defaulted one ledger too early. Changed comparison from<to<=so default only applies after the current ledger passes the eligible-after point.Backend
MAX_IDS_PER_REQUEST(100) cap tomarkReadendpoint to prevent unbounded array submissions that could expand into massive SQL IN clauses. Requests exceeding the cap return HTTP 400. Empty arrays handled as no-ops.Infrastructure
matrixandlanguagenesting understrategy, and fixed all step indentations. Workflow now parses cleanly and executes scans for JavaScript/TypeScript and Rust.Testing