fix(backend): use BigInt for on-chain streamId (u64-safe) - #998
Open
TCROWN10 wants to merge 1 commit into
Open
Conversation
Widen Stream.streamId / StreamEvent.streamId to Postgres bigint and keep decoded u64 values as JS bigint through the worker and API parsers so IDs above int4 max no longer fail inserts. Adds a migration and regression coverage for ids > 2^31-1. Closes LabsCrypt#829 Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stream.streamIdandStreamEvent.streamIdfrom PrismaInt(Postgres int4) toBigInt, with a migration that widens both columns and recreates the FK.Number(...); parse route/body IDs viaparseStreamId()and serialize BigInt safely for JSON/SSE.3_000_000_000n) through the worker and validator.Closes #829
Test plan
streamId > 2147483647persists and is readable viaGET /v1/streams/:id