Fix dead Hero CTAs, fake landing stats, wrong chain claims, getUser validation - #1003
Merged
Merged
Conversation
…er validation - Hero: route "Start Streaming" to /dashboard, drop the dead "Governance App" button - Stats: replace fabricated TVL/streams/savings numbers with honest placeholder copy - FAQ: correct the chain-support answer to Stellar/Soroban instead of EVM chains - getUser: validate publicKey (missing/non-string -> 400, bad format -> 400), matching the existing pattern in getUserEvents Closes LabsCrypt#615 Closes LabsCrypt#614 Closes LabsCrypt#612 Closes LabsCrypt#538
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/dashboardvia a NextLink; removed the dead "Governance App" button since there's no governance UI in the repo.$240M+TVL /85k+streams /$4.2Msavings with honest placeholder copy (network/status/settlement info) instead of made-up numbers.getUsernow validatespublicKeythe same waygetUserEventsalready does — missing/non-string returns 400, malformed Stellar key returns 400 — instead of silently passing garbage to Prisma.Test plan
npx eslintclean on the three changed frontend componentsbackend/tests/user.controller.test.tsgetUsersuite: added 400 cases for missing/malformedpublicKey, updated existing 404/200 cases to use valid-format Stellar keysgetUserEventspatternvitestsuite could not be run end-to-end:backend/src/services/sse.service.tscurrently fails to parse onmain(pre-existing, unrelated to this PR — a class method signature appears to have been dropped in a prior merge, e.g.addClient(...)is missing along withisShuttingDown/checkCapacity/getActiveIpCount). This already breaks Backend CI onmainindependently of this change. Flagging separately rather than guessing at the missing implementation in this PR.Closes #615
Closes #614
Closes #612
Closes #538