Skip to content

Fix dead Hero CTAs, fake landing stats, wrong chain claims, getUser validation - #1003

Merged
ogazboiz merged 1 commit into
LabsCrypt:mainfrom
codeX-james:fix-issues-615-614-612-538
Jul 28, 2026
Merged

Fix dead Hero CTAs, fake landing stats, wrong chain claims, getUser validation#1003
ogazboiz merged 1 commit into
LabsCrypt:mainfrom
codeX-james:fix-issues-615-614-612-538

Conversation

@codeX-james

Copy link
Copy Markdown
Contributor

Summary

  • Hero.tsx: "Start Streaming" now routes to /dashboard via a Next Link; removed the dead "Governance App" button since there's no governance UI in the repo.
  • Stats.tsx: replaced fabricated $240M+ TVL / 85k+ streams / $4.2M savings with honest placeholder copy (network/status/settlement info) instead of made-up numbers.
  • FAQ.tsx: corrected the "Which chains do you support?" answer — FlowFi is Stellar/Soroban, not Ethereum/Arbitrum/Optimism/Polygon/Base.
  • user.controller.ts: getUser now validates publicKey the same way getUserEvents already does — missing/non-string returns 400, malformed Stellar key returns 400 — instead of silently passing garbage to Prisma.

Test plan

  • npx eslint clean on the three changed frontend components
  • Updated backend/tests/user.controller.test.ts getUser suite: added 400 cases for missing/malformed publicKey, updated existing 404/200 cases to use valid-format Stellar keys
  • Manually verified the validation regex/control-flow matches the already-tested getUserEvents pattern
  • Full vitest suite could not be run end-to-end: backend/src/services/sse.service.ts currently fails to parse on main (pre-existing, unrelated to this PR — a class method signature appears to have been dropped in a prior merge, e.g. addClient(...) is missing along with isShuttingDown/checkCapacity/getActiveIpCount). This already breaks Backend CI on main independently of this change. Flagging separately rather than guessing at the missing implementation in this PR.

Closes #615
Closes #614
Closes #612
Closes #538

…er validation

- Hero: route "Start Streaming" to /dashboard, drop the dead "Governance App" button
- Stats: replace fabricated TVL/streams/savings numbers with honest placeholder copy
- FAQ: correct the chain-support answer to Stellar/Soroban instead of EVM chains
- getUser: validate publicKey (missing/non-string -> 400, bad format -> 400), matching the existing pattern in getUserEvents

Closes LabsCrypt#615
Closes LabsCrypt#614
Closes LabsCrypt#612
Closes LabsCrypt#538
@ogazboiz
ogazboiz merged commit c850b50 into LabsCrypt:main Jul 28, 2026
3 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants