main -> web

.github/workflows/python-package.yml

@@ -28,8 +28,17 @@ jobs:
   test:
     runs-on: ubuntu-latest
     needs: matrix_prep
+    # A healthy job finishes well inside half an hour; the slowest green ones
+    # observed are around 25 minutes, and that includes building the conda
+    # environment on a cache miss.  GitHub's default is six hours, which is long
+    # enough for a job stuck on the database to hold a runner all morning -- one
+    # recently ran for five and a half.  Fail such a job in an hour instead.
+    timeout-minutes: 60
     strategy:
+      # The devmirror shards share one database.  Bound concurrent jobs so required
+      # functional CI does not become an uncontrolled database load test.
       fail-fast: false
+      max-parallel: 6
       matrix: ${{fromJson(needs.matrix_prep.outputs.matrix)}}
     name: ${{matrix.server}} ${{matrix.folders}}
     steps:

CONTRIBUTORS.yaml

@@ -1,5 +1,5 @@
 # This is the list of contributors to LMFDB
-# They are listed on /acknowledgement and maybe elsewhere
+# They are listed on /acknowledgment and maybe elsewhere
 # the 'name' field is mandatory, all others currently optional
 #  - affil: university or company affiliation
 #  - url: homepage

lmfdb/api2/templates/api2.html

@@ -18,7 +18,7 @@ <h2 id="api2-requests">API2 requests</h2>
 <li><p><a class="uri">/api2/inventory/&lt;searcher&gt;</a> - Describe the list of possible fields that can be returned by a searcher</p></li>
 <li><p><a class="uri">/api2/data/&lt;searcher&gt;</a> - Perform a search using a given searcher. Query parameters taken from the searcher description are provided as an ampersand delimited query string to this endpoint. Non searching parameters are available and are all prepended by “_”</p></li>
 <li><p><a class="uri">/api2/pretty/&lt;other_path&gt;</a> - This takes a valid other API path and produces a human readable (just) HTML page from the data contained. The other path should be the part after “api2” in the URL</p></li>
-<li><p><a class="uri">/api2/singleton/&lt;path&gt;</a> - This is intended to provide a URL that allows canonical reference to a single element of the database. The format of the singletons is not standardised and should not in general be used for machine readable access</p></li>
+<li><p><a class="uri">/api2/singleton/&lt;path&gt;</a> - This is intended to provide a URL that allows canonical reference to a single element of the database. The format of the singletons is not standardized and should not in general be used for machine readable access</p></li>
 <li><p><a class="uri">/api2/livepg/&lt;database&gt;</a> - This is intended to replicate the behavior of the existing API. By specifying a database name and then using a standard search string (as per the /data/&lt;searcher&gt; endpoint) a search is performed on the raw database. This is not intended for normal access, but for debugging and testing purposes only.</p></li>
 </ul>
 <h3 id="api2-singletons">API2 singleton queries</h3>

lmfdb/bianchi_modular_forms/templates/bmf-field_dim_table.html

@@ -47,7 +47,7 @@
 {% endif %}
 <p>{{info.report | safe}}
                     {# we have to decide which option is preselected
-                    based on a judgement of what users will want to
+                    based on a judgment of what users will want to
                     switch to, i.e. one of the other two options.  For
                     simplicity I have used the 3-cycle new -> all ->
                     cusp -> new. #}

lmfdb/bianchi_modular_forms/web_BMF.py

@@ -115,7 +115,7 @@ def __init__(self, dbdata, max_eigs=50):
             - dbdata: the data from the database
 
         dbdata is expected to be a database entry from which the class
-        is initialised.
+        is initialized.
 
         """
         self.__dict__.update(dbdata)

lmfdb/characters/test_characters.py

@@ -35,18 +35,29 @@ def test_modbrowse(self):
         assert '46.d' in W.get_data(as_text=True)
 
     def test_search(self):
-        W = self.tc.get('/Character/Dirichlet/?conductor=15&order=4')
-        assert r'15.e' in W.get_data(as_text=True)
-        W = self.tc.get('/Character/Dirichlet/?conductor=25-50&order=5-7')
-        assert r'25.d' in W.get_data(as_text=True)
-        W = self.tc.get('/Character/Dirichlet/?conductor=25-50&order=5-7&primitive=Yes')
-        assert r'25.d' in W.get_data(as_text=True)
-        W = self.tc.get('/Character/Dirichlet/?conductor=25-50&order=5-7&primitive=No')
-        assert r'50.d' in W.get_data(as_text=True)
-        W = self.tc.get('/Character/Dirichlet/?conductor=25-50&order=5-7&primitive=No&parity=Odd')
-        assert r'56.n' in W.get_data(as_text=True)
-        W = self.tc.get('/Character/Dirichlet/?conductor=25-50&order=5-7&primitive=No&parity=Even')
-        assert r'50.d' in W.get_data(as_text=True)
+        # Each filter is checked in both directions, so a parameter that stops
+        # being parsed widens the search and trips a negative assertion.
+        # Conductor 16, order 4 has a primitive even orbit (16.e), a primitive
+        # odd one (16.f), and imprimitive counterparts at modulus 32.  Labels
+        # carry their tags, since a bare '16.e' also matches '416.e'.
+        page = self.tc.get('/Character/Dirichlet/?conductor=15&order=4').get_data(as_text=True)
+        assert '>15.e<' in page
+        page = self.tc.get('/Character/Dirichlet/?conductor=16&order=4&is_primitive=no').get_data(as_text=True)
+        assert '>32.e<' in page and '>32.f<' in page
+        assert '>16.e<' not in page and '>16.f<' not in page
+        page = self.tc.get('/Character/Dirichlet/?conductor=16&order=4&parity=even').get_data(as_text=True)
+        assert '>16.e<' in page and '>32.e<' in page
+        assert '>16.f<' not in page and '>32.f<' not in page
+        page = self.tc.get('/Character/Dirichlet/?conductor=16&order=4&parity=odd').get_data(as_text=True)
+        assert '>16.f<' in page and '>32.f<' in page
+        assert '>16.e<' not in page and '>32.e<' not in page
+        page = self.tc.get('/Character/Dirichlet/?conductor=16&order=4&is_primitive=no&parity=odd').get_data(as_text=True)
+        assert '>32.f<' in page
+        assert '>16.e<' not in page and '>16.f<' not in page and '>32.e<' not in page
+        # A conductor range matches no index prefix, so this one reads every
+        # orbit of conductor 25-50 before it can sort; allow the timeout page.
+        self.check_args_with_timeout(
+            '/Character/Dirichlet/?conductor=25-50&order=5-7', '>25.d<')
 
     def test_condsearch(self):
         W = self.tc.get('/Character/Dirichlet/?conductor=111')
@@ -131,7 +142,7 @@ def test_dirichletgalorbs(self):
                     r'<td class="center">\(e\left(\frac{115}{714}\right)\)</td>')
         assert table_row in W.get_data(as_text=True)
 
-        # Tests for URL behaviour of characters
+        # Tests for URL behavior of characters
 
         W = self.tc.get('/Character/Dirichlet/5489/banana/100', follow_redirects=True)
         assert bool_string(True) in W.get_data(as_text=True)

lmfdb/classical_modular_forms/web_newform.py

@@ -1028,9 +1028,9 @@ def display_hecke_char_polys(self, num_disp=5):
                  th_wrap('charpoly', '$F_p(T)$'),
                  '  </tr>', '</thead>', '<tbody>']
         loop_count = 0
-        for p, factorisation in hecke_polys_orbits.items():
-            factorisation.sort(key=lambda elt: (elt[0].degree(), elt[1]))
-            charpoly = raw_typeset_poly_factor(factorisation, decreasing=True)
+        for p, factorization in hecke_polys_orbits.items():
+            factorization.sort(key=lambda elt: (elt[0].degree(), elt[1]))
+            charpoly = raw_typeset_poly_factor(factorization, decreasing=True)
             if loop_count < num_disp:
                 polys.append('  <tr>')
             else:

lmfdb/ecnf/WebEllipticCurve.py

@@ -215,12 +215,12 @@ def EC_R_plot_zone(f,h):
         return plot_zone_union(EC_R_plot_zone_piece(f,h,ZF[0],ZF[1]),EC_R_plot_zone_piece(f,h,ZF[2],2*xi-ZF[2]))
     return EC_R_plot_zone_piece(f,h,ZF[0],2*ZF[1]-ZF[0])
 
-def EC_R_plot(ainvs, xmin, xmax, ymin, ymax, colour, legend):
+def EC_R_plot(ainvs, xmin, xmax, ymin, ymax, color, legend):
     x = var('x')
     y = var('y')
     c = (xmin + xmax) / 2
     d = (xmax - xmin)
-    return implicit_plot(y ** 2 + ainvs[0] * x * y + ainvs[2] * y - x ** 3 - ainvs[1] * x ** 2 - ainvs[3] * x - ainvs[4], (x, xmin, xmax), (y, ymin, ymax), plot_points=500, aspect_ratio="automatic", color=colour) + plot(0, xmin=c - 1e-5 * d, xmax=c + 1e-5 * d, ymin=ymin, ymax=ymax, aspect_ratio="automatic", color=colour, legend_label=legend)  # Add an extra plot outside the visible frame because implicit plots are buggy: their legend does not show (https://trac.sagemath.org/ticket/15903)
+    return implicit_plot(y ** 2 + ainvs[0] * x * y + ainvs[2] * y - x ** 3 - ainvs[1] * x ** 2 - ainvs[3] * x - ainvs[4], (x, xmin, xmax), (y, ymin, ymax), plot_points=500, aspect_ratio="automatic", color=color) + plot(0, xmin=c - 1e-5 * d, xmax=c + 1e-5 * d, ymin=ymin, ymax=ymax, aspect_ratio="automatic", color=color, legend_label=legend)  # Add an extra plot outside the visible frame because implicit plots are buggy: their legend does not show (https://trac.sagemath.org/ticket/15903)
 
 Rx = PolynomialRing(RDF,'x')
 
@@ -238,7 +238,7 @@ def EC_nf_plot(K, ainvs, base_field_gen_name):
         xmax = max([r[1] for r in R])
         ymin = min([r[2] for r in R])
         ymax = max([r[3] for r in R])
-        cols = rainbow(n1) # Default choice of n colours
+        cols = rainbow(n1) # Default choice of n colors
         # However, these tend to be too pale, so we preset them for small values of n
         if n1 == 1:
             cols = ["blue"]

lmfdb/ecnf/test_ecnf.py

@@ -59,7 +59,7 @@ def test_j(self):
         L = self.tc.get('/EllipticCurve/2.0.4.1/5525.5/b/9')
         assert '226834389543384' in L.get_data(as_text=True)
         assert '1490902050625' in L.get_data(as_text=True)
-        L = self.tc.get('EllipticCurve/2.2.89.1/81.1/a/1') # Test factorisation
+        L = self.tc.get('EllipticCurve/2.2.89.1/81.1/a/1') # Test factorization
         assert '8798344145175011328000' in L.get_data(as_text=True)
 
     def test_download(self):

lmfdb/elliptic_curves/elliptic_curve.py

@@ -654,7 +654,7 @@ def elliptic_curve_search(info, query):
                     info['galois_image'] = ','.join(modell_labels + elladic_labels)
                 query['modell_images'] = { '$contains': modell_labels }
 
-    # The button which used to be labelled Optimal only no/yes"
+    # The button which used to be labeled Optimal only no/yes"
     # (default: no) has been renamed "Curves per isogeny class
     # all/one" (default: all).  When this option is "one" we only list
     # one curve in each class, currently choosing the curve with

lmfdb/elliptic_curves/isog_class.py

@@ -133,7 +133,7 @@ def make_class(self):
         from sage.matrix.all import Matrix
         M = classdata['isogeny_matrix']
 
-        # permute rows/cols to match labelling: the rows/cols in the
+        # permute rows/cols to match labeling: the rows/cols in the
         # ec_classdata table are with respect to LMFDB ordering.
         if self.label_type == 'Cremona':
             def perm(i): return next(c for c in self.curves if c['Cnumber'] == i+1)['lmfdb_number']-1

lmfdb/elliptic_curves/templates/congruent_number_data.html

@@ -255,7 +255,7 @@ <h3>Distribution of &#1064;</h3>
   Over half the curves ($574,290$) have trivial &#1064;.  The largest value seen is $7396 = 86^2$, for $n=719057$.
 </p>
 
-<h2>Credit and acknowledgements</h2> 
+<h2>Credit and acknowledgments</h2> 
 
 <p>
 The data files were created by Randall L. Rathbun on February 14, 2013

lmfdb/elliptic_curves/templates/ec-isoclass.html

@@ -121,7 +121,7 @@ <h2>{{ KNOWL('ec.isogeny_matrix',title='Isogeny matrix') }}</h2>
 <h2> {{ KNOWL('ec.isogeny_graph', title='Isogeny graph') }} </h2>
 {{ place_code('isogeny_graph') }}
 {% if info.class_size > 1 %}
-<p>The vertices are labelled with {{info.label_type}} labels, and the {{ KNOWL('ec.q.optimal', title='\( \Gamma_0(N) \)-optimal') }} curve is highlighted in blue.</p>
+<p>The vertices are labeled with {{info.label_type}} labels, and the {{ KNOWL('ec.q.optimal', title='\( \Gamma_0(N) \)-optimal') }} curve is highlighted in blue.</p>
 {% endif %}
 <div id="isogeny-graph"></div>
 

lmfdb/elliptic_curves/test_ell_curves.py

@@ -174,10 +174,10 @@ def test_torsion_growth(self):
 
     def test_990h(self):
         """
-        Test the exceptional 990h/990.i optimal labelling.
+        Test the exceptional 990h/990.i optimal labeling.
         """
-        # The isogeny class 990h (Cremona labelling) or 990.i (LMFDB labelling)
-        # has a different Gamma-optimal curve in its labelling than all others.
+        # The isogeny class 990h (Cremona labeling) or 990.i (LMFDB labeling)
+        # has a different Gamma-optimal curve in its labeling than all others.
         L = self.tc.get('/EllipticCurve/Q/990/i/')
         row = '\n'.join([
             '<td class="center"><a href="/EllipticCurve/Q/990h3/">990h3</a></td>',

lmfdb/elliptic_curves/web_ec.py

@@ -520,7 +520,7 @@ def red(p):
         # Optimality
 
         # The optimal curve in the class is the curve whose Cremona
-        # label ends in '1' except for '990h' which was labelled
+        # label ends in '1' except for '990h' which was labeled
         # wrongly long ago. This is proved for N up to
         # OPTIMALITY_BOUND (and when there is only one curve in an
         # isogeny class, obviously) and expected for all N.

lmfdb/genus2_curves/templates/g2c_curve.html

@@ -188,7 +188,7 @@ <h2> {{KNOWL('g2c.bsd_invariants', 'BSD invariants')}} </h2>
     <tr><td>{{ KNOWL('lfunction.leading_coeff', 'Leading coefficient') }}:</td>
         <td>{% if data.leading_coefficient == 'unknown' %} unknown {% else %} \( {{ data.leading_coeff }} \) {% endif %}</td></tr>
     <tr><td>{{ KNOWL('g2c.analytic_sha', 'Analytic order of &#1064;') }}:</td>
-        <td>{% if data.analytic_sha != 0 %} \( {{data.analytic_sha}} \) &nbsp;&nbsp;(rounded) {% else %} unknown {% endif %}</td></tr>
+        <td>{% if data.analytic_sha != 0 %} \( {{data.analytic_sha}} \) &nbsp;&nbsp;{% if data.sha_proved %}(verified) {% else %}(rounded){% endif %} {% else %}unknown{% endif %}</td></tr>
     <tr><td>{{ KNOWL('g2c.has_square_sha', 'Order of &#1064;') }}:</td><td>{{data.has_square_sha}}</td></tr>
 </table>
 </p>

lmfdb/genus2_curves/web_g2c.py

@@ -858,6 +858,7 @@ def make_object(self, curve, endo, tama, ratpts, clus, galrep, nonsurj, is_curve
         data['mw_rank_proved'] = curve['mw_rank_proved']
         data['analytic_rank_proved'] = curve['analytic_rank_proved']
         data['hasse_weil_proved'] = curve['hasse_weil_proved']
+        data['sha_proved'] = curve.get('sha_proved',False)
         data['st_group'] = curve['st_group']
         data['st_group_link'] = st_display_knowl(curve['st_label'])
         data['st0_group_name'] = st0_group_name(curve['real_geom_end_alg'])

lmfdb/groups/abstract/code.yaml

@@ -21,6 +21,9 @@ presentation:
   sage_gap: |
     # This uses Sage's interface to GAP, as Sage (currently) has no native support for PC groups
     G = gap.new('PcGroupCode({pccode},{ordgp})'); {sage_gap_assign}
+  oscar: |
+    # This uses Oscar's interface to GAP, as Oscar (currently) has no native support for PC groups
+    G = PcGroup(GAP.evalstr("PcGroupCode({pccode},{ordgp})")); {oscar_assign}
 
 permutation:
   comment: Define the group as a permutation group
@@ -510,3 +513,35 @@ snippet_test:
   testA5:
     label: A5
     url: Groups/Abstract/60.5/codedownload/{lang}
+
+  # Tests for the group construction download pages
+  # (incl. constructing the boolean invariants and character table)
+  testC1data:
+    label: C1-data
+    langs: [sage, magma]
+    url: Groups/Abstract/1.1/download/{lang}
+  testC5data:
+    label: C5-data
+    langs: [sage, magma]
+    url: Groups/Abstract/5.1/download/{lang}
+  testS3data:
+    label: S3-data
+    langs: [sage, magma]
+    url: Groups/Abstract/6.1/download/{lang}
+  testD4data:
+    label: D4-data
+    langs: [sage, magma]
+    url: Groups/Abstract/8.3/download/{lang}
+  testQ8data:
+    label: Q8-data
+    langs: [sage, magma]
+    url: Groups/Abstract/8.4/download/{lang}
+  test_matrix_reps_data:
+    label: "32_14-data"
+    langs: [sage, magma]
+    url: Groups/Abstract/32.14/download/{lang}
+  testA5data:
+    label: A5-data
+    langs: [sage, magma]
+    url: Groups/Abstract/60.5/download/{lang}
+