Skip to content

Locata dataset - #34

Open
fakufaku wants to merge 12 commits into
masterfrom
locata_dataset
Open

fakufaku wants to merge 12 commits into
masterfrom
locata_dataset

Conversation

@fakufaku

Copy link
Copy Markdown
Collaborator

I added support for the LOCATA challenge dataset. This is a dataset of real recordings where the goal is to locate static and moving sources using a few different microphone arrays.

@fakufaku
fakufaku requested a review from ebezzam June 12, 2018 09:49
Comment thread pyroomacoustics/datasets/locata.py Outdated
Attributes
----------
basedir: str, option
The directory where the CMU ARCTIC corpus is located/downloaded. By

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change "CMU ARTIC corpus"

Comment thread pyroomacoustics/datasets/locata.py Outdated
basedir: str, option
The directory where the CMU ARCTIC corpus is located/downloaded. By
default, this is the current directory.
recordings: list of CMUArcticSentence

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

Comment thread pyroomacoustics/datasets/locata.py Outdated
Parameters
----------
basedir: str, optional
The directory where the CMU ARCTIC corpus is located/downloaded. By

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CMU

Comment thread pyroomacoustics/datasets/locata.py Outdated
array: str or list of str, optional
The arrays to read in
dev: bool
Set to True to restrict to dev data, False to eval data. Not setting

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can write True/False as True/False so that it is formatted

Comment thread pyroomacoustics/datasets/locata.py Outdated
array: str
The array used
dev: bool
Wether this a development or evaluation recording

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whether

@fakufaku

Copy link
Copy Markdown
Collaborator Author

@ebezzam Thanks for the comments. I tried to correct all that and improve some. Also checked the doc builds correctly.

@fakufaku fakufaku self-assigned this Jun 28, 2022

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants