Migrate iframe widget to WidgetPropsV2#3877
Merged
Merged
Conversation
Contributor
|
Size Change: +32 B (+0.01%) Total Size: 517 kB 📦 View Changed
ℹ️ View Unchanged
|
handeyeco
approved these changes
Jul 9, 2026
| /** Whether to allow the iframe content to redirect the page */ | ||
| /** | ||
| * Whether to allow the iframe content to redirect the page | ||
| * @deprecated - not used in Perseus. |
| const style = { | ||
| width: String(this.props.width), | ||
| height: String(this.props.height), | ||
| width: String(this.props.options.width), |
Contributor
There was a problem hiding this comment.
Wonder if it's worth destructuring at the start of render so we don't have these this.props.options in several places.
benchristel
force-pushed
the
benc/widget-props-3
branch
3 times, most recently
from
1278560 to
1b50504
Compare
benchristel
force-pushed
the
benc/widget-props-4
branch
from
ad9ed8e to
a11a2c8
Compare
Base automatically changed from
benc/widget-props-3
to
benc/widget-props-redesign
July 9, 2026 17:51
benchristel
force-pushed
the
benc/widget-props-4
branch
from
a11a2c8 to
4300c26
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This continues the work started in #3869.
I removed the default props because:
allowFullScreencan't be undefined, so the default was never used.allowTopNavigationwasn't used by the component.Issue: LEMS-4354
Test plan:
pnpm storybookperseus-renderer-upgradefeature flag on.