fix(LEMS-3965): Move issues panel out of item editor#3827
Conversation
…r, remove code from item editor
|
Size Change: +133 B (+0.03%) Total Size: 517 kB 📦 View Changed
ℹ️ View Unchanged
|
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (a89d3b3) and published it to npm. You Example: pnpm add @khanacademy/perseus@PR3827If you are working in Khan Academy's frontend, you can run the below command. ./dev/tools/bump_perseus_version.ts -t PR3827If you are working in Khan Academy's webapp, you can run the below command. ./dev/tools/bump_perseus_version.js -t PR3827 |
…es/origin/main' into move-issues-panel-and-add-hints
… out of item editor into editor
nishasy
left a comment
There was a problem hiding this comment.
This looks amazing! It's so clean, and I appreciate the tests. The logic seems sound to me.
One note: I did land the editor page preview scroll PR, so you might have to double check that the issues panel still looks correct within the left cell after merging main.
| )} | ||
|
|
||
| {(!this.props.developerMode || !this.props.jsonMode) && ( | ||
| {showEditor && ( |
There was a problem hiding this comment.
Nit: Is there a reason that this has showEditor && three separate times? Is it possible to wrap these three sections in a fragment <> </> and only have the showEditor && once?
There was a problem hiding this comment.
I didn't want to touch too much since all of this is going to stripped away in Jeremy's editor decomp
…es/origin/main' into move-issues-panel-and-add-hints
…es/origin/main' into move-issues-panel-and-add-hints
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @khanacademy/perseus@80.0.0 ### Major Changes - [#3843](#3843) [`47f9f11`](47f9f11) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - [number-line] Narrow `labelStyle` type to the supported list of styles: "decimal", "improper", "mixed", and "non-reduced". Also removes legacy code for long-removed label style `"decimal ticks"`. ### Patch Changes - [#3849](#3849) [`45fbde7`](45fbde7) Thanks [@nishasy](https://github.com/nishasy)! - [ColorSync][Plotter] Add Plotter visual regression stories - [#3753](#3753) [`cbd7ea7`](cbd7ea7) Thanks [@catandthemachines](https://github.com/catandthemachines)! - Re-organize interactive graph string files to centralize string patterns and streamline testing. - [#3844](#3844) [`86593cf`](86593cf) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Fix crash in Graphie consumers when a labelStyle is used that is invalid (causing an 'undefined' entity to be added to Graphi'es tracking list of entities - resulting in a call to `.toFront()` on this `undefined` entity). - [#3856](#3856) [`387df6c`](387df6c) Thanks [@nishasy](https://github.com/nishasy)! - [ColorSync][Interactive Graph] Use semantic tokens in the Interactive Graph widget - [#3870](#3870) [`15bdd71`](15bdd71) Thanks [@ivyolamit](https://github.com/ivyolamit)! - Fix thin border around the interactive graph - [#3771](#3771) [`024ef46`](024ef46) Thanks [@SonicScrewdriver](https://github.com/SonicScrewdriver)! - Fix table (and block math) text not scaling with the device font scale on mobile: Zoomable now fits content to the zoom-adjusted container width instead of cancelling out the CSS zoom applied for font enlargement - Updated dependencies \[[`b5f7a73`](b5f7a73), [`47f9f11`](47f9f11)]: - @khanacademy/perseus-core@31.0.0 - @khanacademy/math-input@26.6.0 - @khanacademy/keypad-context@3.2.73 - @khanacademy/kmath@2.4.32 - @khanacademy/perseus-linter@5.1.13 - @khanacademy/perseus-score@8.12.5 ## @khanacademy/perseus-core@31.0.0 ### Major Changes - [#3843](#3843) [`47f9f11`](47f9f11) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - [number-line] Narrow `labelStyle` type to the supported list of styles: "decimal", "improper", "mixed", and "non-reduced". Also removes legacy code for long-removed label style `"decimal ticks"`. ### Minor Changes - [#3862](#3862) [`b5f7a73`](b5f7a73) Thanks [@handeyeco](https://github.com/handeyeco)! - Add support for subscript in the MathInput keypad ## @khanacademy/math-input@26.6.0 ### Minor Changes - [#3862](#3862) [`b5f7a73`](b5f7a73) Thanks [@handeyeco](https://github.com/handeyeco)! - Add support for subscript in the MathInput keypad ### Patch Changes - Updated dependencies \[[`b5f7a73`](b5f7a73), [`47f9f11`](47f9f11)]: - @khanacademy/perseus-core@31.0.0 - @khanacademy/keypad-context@3.2.73 ## @khanacademy/keypad-context@3.2.73 ### Patch Changes - Updated dependencies \[[`b5f7a73`](b5f7a73), [`47f9f11`](47f9f11)]: - @khanacademy/perseus-core@31.0.0 ## @khanacademy/kmath@2.4.32 ### Patch Changes - Updated dependencies \[[`b5f7a73`](b5f7a73), [`47f9f11`](47f9f11)]: - @khanacademy/perseus-core@31.0.0 ## @khanacademy/perseus-editor@34.2.1 ### Patch Changes - [#3870](#3870) [`15bdd71`](15bdd71) Thanks [@ivyolamit](https://github.com/ivyolamit)! - Fix thin border around the interactive graph - [#3827](#3827) [`4ca460f`](4ca460f) Thanks [@anakaren-rojas](https://github.com/anakaren-rojas)! - Moves issues panel out of item editor into editor - Updated dependencies \[[`45fbde7`](45fbde7), [`b5f7a73`](b5f7a73), [`cbd7ea7`](cbd7ea7), [`86593cf`](86593cf), [`387df6c`](387df6c), [`15bdd71`](15bdd71), [`47f9f11`](47f9f11), [`024ef46`](024ef46)]: - @khanacademy/perseus@80.0.0 - @khanacademy/perseus-core@31.0.0 - @khanacademy/math-input@26.6.0 - @khanacademy/keypad-context@3.2.73 - @khanacademy/kmath@2.4.32 - @khanacademy/perseus-linter@5.1.13 ## @khanacademy/perseus-linter@5.1.13 ### Patch Changes - Updated dependencies \[[`b5f7a73`](b5f7a73), [`47f9f11`](47f9f11)]: - @khanacademy/perseus-core@31.0.0 - @khanacademy/kmath@2.4.32 ## @khanacademy/perseus-score@8.12.5 ### Patch Changes - Updated dependencies \[[`b5f7a73`](b5f7a73), [`47f9f11`](47f9f11)]: - @khanacademy/perseus-core@31.0.0 - @khanacademy/kmath@2.4.32 Author: khan-actions-bot Reviewers: jeremywiebe Required Reviewers: Approved By: jeremywiebe Checks: ✅ 11 checks were successful Pull Request URL: #3871
Summary:
Issue: LEMS-3965
Test plan:
ZND
Validated Hint Linter warnings are pulled into Issues Panel
Screen.Recording.2026-07-01.at.11.11.27.mov
Screen.Recording.2026-07-01.at.11.46.56.mov
Screen.Recording.2026-07-01.at.11.38.04.mov