Skip to content

fix(LEMS-3965): Move issues panel out of item editor#3827

Merged
anakaren-rojas merged 8 commits into
mainfrom
move-issues-panel-and-add-hints
Jul 9, 2026
Merged

fix(LEMS-3965): Move issues panel out of item editor#3827
anakaren-rojas merged 8 commits into
mainfrom
move-issues-panel-and-add-hints

Conversation

@anakaren-rojas

@anakaren-rojas anakaren-rojas commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Summary:

  • Moves issues panel out of item editor and into editor page
  • Adds hints linting into issues panel
  • Adds tests for new functions
  • Exports Issues Panel

Issue: LEMS-3965

Test plan:

ZND
Validated Hint Linter warnings are pulled into Issues Panel

  • Opening an existing item with hint issues shows them in the Issues Panel immediately
  • Issues from multiple hints appear as distinct entries, each labeled with their hint number
  • Adding a hint with a linting issue registers it in the Issues Panel
  • Removing a hint removes its issues from the Issues Panel
  • Reordering hints updates the hint numbers on their issues
  • A clean item shows 0 issues in the Issues Panel
Screen.Recording.2026-07-01.at.11.11.27.mov
Screen.Recording.2026-07-01.at.11.46.56.mov
Screen.Recording.2026-07-01.at.11.38.04.mov

@github-actions

github-actions Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Size Change: +133 B (+0.03%)

Total Size: 517 kB

📦 View Changed
Filename Size Change
packages/perseus-editor/dist/es/index.js 104 kB +133 B (+0.13%)
ℹ️ View Unchanged
Filename Size
packages/kas/dist/es/index.js 20.6 kB
packages/keypad-context/dist/es/index.js 1 kB
packages/kmath/dist/es/index.js 6.31 kB
packages/math-input/dist/es/index.js 98.5 kB
packages/math-input/dist/es/strings.js 1.61 kB
packages/perseus-core/dist/es/index.item-splitting.js 12.9 kB
packages/perseus-core/dist/es/index.js 27.7 kB
packages/perseus-linter/dist/es/index.js 9.79 kB
packages/perseus-score/dist/es/index.js 9.86 kB
packages/perseus-utils/dist/es/index.js 403 B
packages/perseus/dist/es/index.js 204 kB
packages/perseus/dist/es/strings.js 12.4 kB
packages/pure-markdown/dist/es/index.js 1.39 kB
packages/simple-markdown/dist/es/index.js 6.71 kB

compressed-size-action

@github-actions

github-actions Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

npm Snapshot: Published

Good news!! We've packaged up the latest commit from this PR (a89d3b3) and published it to npm. You
can install it using the tag PR3827.

Example:

pnpm add @khanacademy/perseus@PR3827

If you are working in Khan Academy's frontend, you can run the below command.

./dev/tools/bump_perseus_version.ts -t PR3827

If you are working in Khan Academy's webapp, you can run the below command.

./dev/tools/bump_perseus_version.js -t PR3827

@anakaren-rojas anakaren-rojas marked this pull request as ready for review July 1, 2026 20:06
@anakaren-rojas anakaren-rojas requested a review from a team July 1, 2026 20:07
@anakaren-rojas anakaren-rojas changed the title fix(LEMS-3965): Add hints to issues panel fix(LEMS-3965): Move issues panel out of item editor Jul 1, 2026

@nishasy nishasy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks amazing! It's so clean, and I appreciate the tests. The logic seems sound to me.

One note: I did land the editor page preview scroll PR, so you might have to double check that the issues panel still looks correct within the left cell after merging main.

)}

{(!this.props.developerMode || !this.props.jsonMode) && (
{showEditor && (

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Is there a reason that this has showEditor && three separate times? Is it possible to wrap these three sections in a fragment <> </> and only have the showEditor && once?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't want to touch too much since all of this is going to stripped away in Jeremy's editor decomp

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!

@anakaren-rojas anakaren-rojas merged commit 4ca460f into main Jul 9, 2026
10 checks passed
@anakaren-rojas anakaren-rojas deleted the move-issues-panel-and-add-hints branch July 9, 2026 18:32
jeremywiebe pushed a commit that referenced this pull request Jul 10, 2026
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.


# Releases
## @khanacademy/perseus@80.0.0

### Major Changes

-   [#3843](#3843) [`47f9f11`](47f9f11) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - [number-line] Narrow `labelStyle` type to the supported list of styles: "decimal", "improper", "mixed", and "non-reduced". Also removes legacy code for long-removed label style `"decimal ticks"`.

### Patch Changes

-   [#3849](#3849) [`45fbde7`](45fbde7) Thanks [@nishasy](https://github.com/nishasy)! - [ColorSync][Plotter] Add Plotter visual regression stories

-   [#3753](#3753) [`cbd7ea7`](cbd7ea7) Thanks [@catandthemachines](https://github.com/catandthemachines)! - Re-organize interactive graph string files to centralize string patterns and streamline testing.

-   [#3844](#3844) [`86593cf`](86593cf) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - Fix crash in Graphie consumers when a labelStyle is used that is invalid (causing an 'undefined' entity to be added to Graphi'es tracking list of entities - resulting in a call to `.toFront()` on this `undefined` entity).

-   [#3856](#3856) [`387df6c`](387df6c) Thanks [@nishasy](https://github.com/nishasy)! - [ColorSync][Interactive Graph] Use semantic tokens in the Interactive Graph widget

-   [#3870](#3870) [`15bdd71`](15bdd71) Thanks [@ivyolamit](https://github.com/ivyolamit)! - Fix thin border around the interactive graph

-   [#3771](#3771) [`024ef46`](024ef46) Thanks [@SonicScrewdriver](https://github.com/SonicScrewdriver)! - Fix table (and block math) text not scaling with the device font scale on mobile: Zoomable now fits content to the zoom-adjusted container width instead of cancelling out the CSS zoom applied for font enlargement

-   Updated dependencies \[[`b5f7a73`](b5f7a73), [`47f9f11`](47f9f11)]:
    -   @khanacademy/perseus-core@31.0.0
    -   @khanacademy/math-input@26.6.0
    -   @khanacademy/keypad-context@3.2.73
    -   @khanacademy/kmath@2.4.32
    -   @khanacademy/perseus-linter@5.1.13
    -   @khanacademy/perseus-score@8.12.5

## @khanacademy/perseus-core@31.0.0

### Major Changes

-   [#3843](#3843) [`47f9f11`](47f9f11) Thanks [@jeremywiebe](https://github.com/jeremywiebe)! - [number-line] Narrow `labelStyle` type to the supported list of styles: "decimal", "improper", "mixed", and "non-reduced". Also removes legacy code for long-removed label style `"decimal ticks"`.

### Minor Changes

-   [#3862](#3862) [`b5f7a73`](b5f7a73) Thanks [@handeyeco](https://github.com/handeyeco)! - Add support for subscript in the MathInput keypad

## @khanacademy/math-input@26.6.0

### Minor Changes

-   [#3862](#3862) [`b5f7a73`](b5f7a73) Thanks [@handeyeco](https://github.com/handeyeco)! - Add support for subscript in the MathInput keypad

### Patch Changes

-   Updated dependencies \[[`b5f7a73`](b5f7a73), [`47f9f11`](47f9f11)]:
    -   @khanacademy/perseus-core@31.0.0
    -   @khanacademy/keypad-context@3.2.73

## @khanacademy/keypad-context@3.2.73

### Patch Changes

-   Updated dependencies \[[`b5f7a73`](b5f7a73), [`47f9f11`](47f9f11)]:
    -   @khanacademy/perseus-core@31.0.0

## @khanacademy/kmath@2.4.32

### Patch Changes

-   Updated dependencies \[[`b5f7a73`](b5f7a73), [`47f9f11`](47f9f11)]:
    -   @khanacademy/perseus-core@31.0.0

## @khanacademy/perseus-editor@34.2.1

### Patch Changes

-   [#3870](#3870) [`15bdd71`](15bdd71) Thanks [@ivyolamit](https://github.com/ivyolamit)! - Fix thin border around the interactive graph

-   [#3827](#3827) [`4ca460f`](4ca460f) Thanks [@anakaren-rojas](https://github.com/anakaren-rojas)! - Moves issues panel out of item editor into editor

-   Updated dependencies \[[`45fbde7`](45fbde7), [`b5f7a73`](b5f7a73), [`cbd7ea7`](cbd7ea7), [`86593cf`](86593cf), [`387df6c`](387df6c), [`15bdd71`](15bdd71), [`47f9f11`](47f9f11), [`024ef46`](024ef46)]:
    -   @khanacademy/perseus@80.0.0
    -   @khanacademy/perseus-core@31.0.0
    -   @khanacademy/math-input@26.6.0
    -   @khanacademy/keypad-context@3.2.73
    -   @khanacademy/kmath@2.4.32
    -   @khanacademy/perseus-linter@5.1.13

## @khanacademy/perseus-linter@5.1.13

### Patch Changes

-   Updated dependencies \[[`b5f7a73`](b5f7a73), [`47f9f11`](47f9f11)]:
    -   @khanacademy/perseus-core@31.0.0
    -   @khanacademy/kmath@2.4.32

## @khanacademy/perseus-score@8.12.5

### Patch Changes

-   Updated dependencies \[[`b5f7a73`](b5f7a73), [`47f9f11`](47f9f11)]:
    -   @khanacademy/perseus-core@31.0.0
    -   @khanacademy/kmath@2.4.32

Author: khan-actions-bot

Reviewers: jeremywiebe

Required Reviewers:

Approved By: jeremywiebe

Checks: ✅ 11 checks were successful

Pull Request URL: #3871
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants