Skip to content

Fix: Drop Django pin and register netbox.plugins entry point - #119

Merged
Kani999 merged 2 commits into
mainfrom
118-plugin-entry-point
Oct 1, 2026
Merged

Kani999 merged 2 commits into
mainfrom
118-plugin-entry-point

Conversation

@Kani999

@Kani999 Kani999 commented Oct 1, 2026 •

Copy link
Copy Markdown
Owner

Closes #118

  • Remove the django>=6.1,<7.0 pin from dependencies and the test extra. NetBox pins Django itself.
  • Add [project.entry-points."netbox.plugins"] → netbox_attachments:config for NetBox 4.7 plugin discovery.

pytest -q: 98 passed.

Summary by CodeRabbit

  • New Features

    • The attachments package is now discoverable as a NetBox plugin through standard plugin registration.
  • Installation

    • Installing the package no longer installs Django as a runtime dependency. The optional test setup now installs pytest without Django.

@coderabbitai

coderabbitai Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Advanced

Run ID: 84f84c2f-5681-4f98-a364-0a9712efd535

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
✨ Simplify code
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Kani999
Kani999 merged commit 7c00a21 into main Oct 1, 2026
5 checks passed
@Kani999
Kani999 deleted the 118-plugin-entry-point branch October 1, 2026 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Drop Django pin and add netbox.plugins entry point

1 participant