Skip to content

Add check for hosts that are guests - #34

Open
ChanceM wants to merge 1 commit into
JupiterBroadcasting:mainfrom
ChanceM:bug/add-guest-entry-for-hosts
Open

Add check for hosts that are guests#34
ChanceM wants to merge 1 commit into
JupiterBroadcasting:mainfrom
ChanceM:bug/add-guest-entry-for-hosts

Conversation

@ChanceM

@ChanceM ChanceM commented Sep 8, 2022

Copy link
Copy Markdown
Collaborator

Adds check for guest records that were clobbered by being a host and adds a guest file output.

Fixes JupiterBroadcasting/jupiterbroadcasting.com#376

@gerbrent

gerbrent commented Sep 8, 2022

Copy link
Copy Markdown
Contributor

@elreydetoda wanna have a look at this one too? Low-ish priority.

@elreydetoda

Copy link
Copy Markdown
Collaborator

Ya, I can try and take a look at it this weekend.

The scraper is currently a lot more difficult to validate consistency, and I want to make sure I don't break anything with plenty of time to validate changes.

@gerbrent

gerbrent commented Sep 9, 2022

Copy link
Copy Markdown
Contributor

This is the way.

@gerbrent
gerbrent requested a review from elreydetoda September 9, 2022 04:11
@ChanceM

ChanceM commented Sep 17, 2022

Copy link
Copy Markdown
Collaborator Author

@elreydetoda I noticed there is a bash script in the repo that links all hosts to guests... seems a small assumption, but probably safe. I still think the cascade method might be something to look at since it does look like JB is accepting PRs against the people content for future updates not populated by the scrapper.

It might be a messy rebuild but would set it up for easier updates to both profiles while also being flexible enough to allow changes to just one if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

guest vs host - profile type and how people are categorized

3 participants