Add rotate option to profile_solvers layout#201
Conversation
…bjects directly. It now asserts size(p.layout.grid) == (4, 2) for the default layout and (2, 4) for rotate = true, which is stable and avoids the false failure I saw in CI.
profile_solvers layout
There was a problem hiding this comment.
Pull request overview
Adds a rotate keyword to profile_solvers to allow swapping the layout orientation of the generated profile grid.
Changes:
- Introduce
rotate::Bool = falsetoprofile_solversand adjustlayout/sizecomputation accordingly. - Document the new
rotatekeyword in theprofile_solversdocstring. - Update
test/profiles.jlto exerciserotate = true.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/profiles.jl |
Adds rotate keyword and uses it to compute plot grid dimensions and figure size. |
test/profiles.jl |
Calls profile_solvers with rotate = true as part of smoke testing plot generation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…navk23/SolverBenchmark.jl into fix-issue-115-rotate-profiles
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #201 +/- ##
===========================================
+ Coverage 76.71% 87.22% +10.51%
===========================================
Files 12 10 -2
Lines 292 321 +29
===========================================
+ Hits 224 280 +56
+ Misses 68 41 -27 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@arnavk23 Could you please show an example of a plot with |
|
@dpo Seeing |
dpo
left a comment
There was a problem hiding this comment.
Thank you. When rotate = true, the titles are misplaced. Which plots are for elapsed time, and which are for evaluations?
|
@dpo Updated plot |
|
I think the titles are still in weird places:
I think
|
dpo
left a comment
There was a problem hiding this comment.
Thank you! I think it looks alright now.




@dpo @tmigot
Fixes #115