[WIP] RL-RBF-G Transfer Operator#245
Open
AbdAlazezAhmed wants to merge 10 commits into
Open
Conversation
4 tasks
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #245 +/- ##
==========================================
+ Coverage 73.03% 73.87% +0.83%
==========================================
Files 78 78
Lines 6865 7097 +232
==========================================
+ Hits 5014 5243 +229
- Misses 1851 1854 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
There was a problem hiding this comment.
Manifest needs a manual update.
Collaborator
Author
There was a problem hiding this comment.
Can we remove it?
Collaborator
There was a problem hiding this comment.
No, we want this to be precisely reproducibe. Not fixing the Manifest can yield to random doc build failures.
Comment on lines
+49
to
+54
| for dof_i in dofs | ||
| for dof_j in dofs | ||
| adj[dof_i, dof_j] = | ||
| norm(nodes[dof_to_node_map[dof_i]] - nodes[dof_to_node_map[dof_j]]) | ||
| end | ||
| end |
Collaborator
There was a problem hiding this comment.
What is this doing here?
| source_graph, | ||
| GraphsVertices(source_graph), | ||
| distances_source, | ||
| parallel = :threads, |
Comment on lines
+272
to
+273
| Rescale, | ||
| Geodesic, |
Collaborator
There was a problem hiding this comment.
Why do we need this as a type parameter?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for #55