Skip to content

✨ QD-15804 Pass dataSharingAllowed from the license response to the linter - #1062

Merged
Jakub Andrzejewski (bonepl) merged 3 commits into
mainfrom
andrzejewski/QD-15804
Oct 6, 2026
Merged

Jakub Andrzejewski (bonepl) merged 3 commits into
mainfrom
andrzejewski/QD-15804

Conversation

@bonepl

Copy link
Copy Markdown
Contributor

Pull Request Details

The linter needs to know whether Qodana Cloud allows data sharing for the organization. The CLI already calls /linters/license-key but ignored the optional field dataSharingAllowed.

Description

  • LicenseData has a new field DataSharingAllowed. It is optional, and a missing field means false.
  • getScanPropertiesMap adds -Dqodana.data.sharing.allowed=<true|false> when the CLI made the request. The CLI adds nothing when it made no request, for example when there is no token.
  • A manual --property qodana.data.sharing.allowed=... overrides the API value, like all CLI overrides.

Related Issue

QD-15804

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My commit messages are styled with gitmoji
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@bonepl
Jakub Andrzejewski (bonepl) requested a review from a team as a code owner October 5, 2026 10:27

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d5b22ae7aa

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "Codex (@codex) review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "Codex (@codex) address that feedback".

Comment thread internal/core/properties.go
@bonepl

Copy link
Copy Markdown
Contributor Author

Codex (@codex) review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🚀

Reviewed commit: 6faf4b0c0a

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "Codex (@codex) review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "Codex (@codex) address that feedback".

Comment thread internal/cloud/license.go
@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown

Qodana for Go

131 new problems were found

Inspection name Severity Problems
Check dependency licenses 🔴 Failure 5
Vulnerable declared dependency 🔴 Failure 3
Check GO source code coverage 🔶 Warning 64
Unhandled error 🔶 Warning 13
Potential resource leak 🔶 Warning 6
Check dependency licenses 🔶 Warning 4
Deprecated element 🔶 Warning 4
Imported package name as a name identifier 🔶 Warning 3
Vulnerable declared dependency 🔶 Warning 3
Reserved word used as name 🔶 Warning 1
Unsorted imports ◽️ Notice 9
Name starts with a package name ◽️ Notice 8
Empty slice declared using a literal ◽️ Notice 3
Vulnerable declared dependency ◽️ Notice 3
Comment of exported element starts with the incorrect name ◽️ Notice 1
Redundant type conversion ◽️ Notice 1
@@ Code coverage @@
+ 66% total lines covered
11521 lines analyzed, 7643 lines covered
# Calculated according to the filters of your coverage tool

☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@bonepl
Jakub Andrzejewski (bonepl) merged commit 7175a9c into main Oct 6, 2026
15 checks passed
@bonepl
Jakub Andrzejewski (bonepl) deleted the andrzejewski/QD-15804 branch October 6, 2026 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants