IJPL-92400 Support GitHub alert syntax#189
Merged
Ilia Permiashkin (p3rmiashkin) merged 2 commits intoJun 3, 2026
Merged
Conversation
Ilia Permiashkin (p3rmiashkin)
requested a review
from Peter Gromov (donnerpeter)
Peter Gromov (donnerpeter)
approved these changes
Jun 3, 2026
Peter Gromov (donnerpeter)
requested changes
Jun 3, 2026
Peter Gromov (donnerpeter)
left a comment
Peter Gromov (donnerpeter)
left a comment
Member
There was a problem hiding this comment.
Tests fail
Ilia Permiashkin (p3rmiashkin)
requested a review
from Peter Gromov (donnerpeter)
Contributor
Author
|
All tests seem to pass now |
Peter Gromov (donnerpeter)
approved these changes
Jun 3, 2026
Member
|
What was wrong with regexes? |
Contributor
Author
|
I don't think there was anything wrong with them. As Ivan said, this repo is based on the Kotlin Multiplatform framework, so JS wasn't happy about them for some reason, so I switched to simple string matching |
Contributor
Author
|
Claude says the JS regex engine disguises brackets differently (compared to the Java engine) and it wasn't happy about |
Ilia Permiashkin (p3rmiashkin)
merged commit 037769f
into
JetBrains:master
3 checks passed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.