Fix frame drops when dragging scrollable content#3171
Merged
Conversation
Vendula Švastalová (svastven)
approved these changes
Jun 30, 2026
Ivan Matkov (MatkovIvan)
approved these changes
Jul 1, 2026
| // Fixes the issue when the `sendPointerEvent` does not trigger `setNeedsRedraw` synchronously, | ||
| // which lead to frame drops during input. | ||
| // TODO: Remove after CMP-10411 | ||
| Snapshot.sendApplyNotifications() |
Collaborator
There was a problem hiding this comment.
Can we write a test for it to avoid regressions? I know it's not reproducible on Simulators, but maybe we can control event sequence perversely enough in the test environment
Vladimir Mazunin (mazunin-v-jb)
approved these changes
Jul 1, 2026
Ivan Matkov (MatkovIvan)
added a commit
that referenced
this pull request
Jul 2, 2026
This reverts commit 96897e9.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On iOS it's required to receive invalidation synchronously right after input event processing, otherwise the invalidation won't trigger the closest frame to render.
sendApplyNotificationsperforms all events that where scheduled during the touch processing.Fixes https://youtrack.jetbrains.com/issue/CMP-10397/Compose-drops-frame-on-iOS-when-dragging
Release Notes
Fixes - iOS